On 2013/08/28 09:22:54, Jakob wrote:
LGTM with a question.
https://codereview.chromium.org/23600003/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/23600003/diff/1/test/cctest/cctest.status#newcode56
test/cctest/cctest.status:56: test-cpu-profiler/*: PASS || FLAKY
Would it be enough to just have the following?
test-cpu-profiler/*: FLAKY
That was what I tried first. This results in FLAKY being the only expected
result and PASS is not in [FLAKY]. Maybe we have to rethink the design a
little
bit here, since FLAKY is a modifier while PASS, etc are expectations.
https://codereview.chromium.org/23600003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
