https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc#newcode1320
src/assembler.cc:1320: Isolate* isolate) {
4 spaces indent
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc#newcode1327
src/assembler.cc:1327: Isolate* isolate) {
4 spaces indent
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc#newcode2320
src/objects.cc:2320: profiler->NewObjectEvent(elms->address(),
elms->Size());
yes, an update object size event would be the right thing here.
https://codereview.chromium.org/22852024/diff/8001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/serialize.cc#newcode602
src/serialize.cc:602: Add(address, LAZY_DEOPTIMIZATION, 64 + entry,
"lazy_deopt");
64 => 66
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h#newcode1701
src/spaces.h:1701: MUST_USE_RESULT inline MaybeObject* AllocateRaw(int
size_in_bytes);
Instead of adding multiple allocation methods to space, can we do
AllocateRaw(int size_in_bytes, AllocationType event);? Where
AllocationType is an enum that encodes the type of allocation (new
allocation or migration).
https://codereview.chromium.org/22852024/diff/8001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/x64/macro-assembler-x64.h#newcode1058
src/x64/macro-assembler-x64.h:1058: int object_size);
Can we move these methods after the Allocate(...) methods and add a
comment.
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
