As discussed offline: Instead of creating a new "synchronization" directory,
let's use a more general "platform" directory for OS-dependent artifacts.
https://codereview.chromium.org/23625003/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode371
src/isolate.cc:371: }
This introduces a potential race as we might allocate two per isolate
data structures and the thread_data_table will be accessed concurrently.
https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1753
src/isolate.cc:1753: // Must be initialized early to allow
v8::SetResourceConstraints calls.
Comment applied to the line being removed, let's also drop the comment.
https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1755
src/isolate.cc:1755: // Must be initialized early to allow v8::Debug
calls.
Comment applied to the line being removed, let's also drop the comment.
https://codereview.chromium.org/23625003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
