I really like this cleanup, just a couple of minor questions.
https://codereview.chromium.org/23608004/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/23608004/diff/1/src/deoptimizer.cc#newcode2587
src/deoptimizer.cc:2587: if
(!interrupt_stub.FindCodeInCache(&interrupt_code, isolate)) return;
Should this be an error?
https://codereview.chromium.org/23608004/diff/1/src/deoptimizer.cc#newcode2630
src/deoptimizer.cc:2630: ASSERT_NE(NOT_PATCHED,
GetInterruptPatchState(isolate,
ASSERT_EQ(PATCHED_FOR_OSR, ... ?
https://codereview.chromium.org/23608004/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/23608004/diff/1/src/deoptimizer.h#newcode265
src/deoptimizer.h:265: static void VerifyInterruptCode(Isolate* isolate,
Maybe this should take a patch state to check against?
https://codereview.chromium.org/23608004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
