lgtm with nits
https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc#newcode129
src/hydrogen-escape-analysis.cc:129: HCapturedObject* state, HCheckMaps*
mapcheck) {
Syntax nit: each argument on a single line.
https://codereview.chromium.org/23697002/diff/3001/src/hydrogen-escape-analysis.cc#newcode131
src/hydrogen-escape-analysis.cc:131: HValue* value =
state->values()->first();
Can we have a helper method map_value() on HCapturedObject?
https://codereview.chromium.org/23697002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
