Revision: 16404
Author: [email protected]
Date: Wed Aug 28 14:26:22 2013 UTC
Log: Remove obsolete Oddball setters in FixedArray.
[email protected]
Review URL: https://codereview.chromium.org/23705002
http://code.google.com/p/v8/source/detail?r=16404
Modified:
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/mark-compact.cc
/branches/bleeding_edge/src/objects-inl.h
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/heap.cc Wed Aug 28 08:39:43 2013 UTC
+++ /branches/bleeding_edge/src/heap.cc Wed Aug 28 14:26:22 2013 UTC
@@ -3414,7 +3414,7 @@
// Flush the number to string cache.
int len = number_string_cache()->length();
for (int i = 0; i < len; i++) {
- number_string_cache()->set_undefined(this, i);
+ number_string_cache()->set_undefined(i);
}
}
=======================================
--- /branches/bleeding_edge/src/mark-compact.cc Wed Aug 21 18:31:13 2013 UTC
+++ /branches/bleeding_edge/src/mark-compact.cc Wed Aug 28 14:26:22 2013 UTC
@@ -2590,7 +2590,7 @@
for (int i = new_number_of_transitions * step;
i < number_of_transitions * step;
i++) {
- prototype_transitions->set_undefined(heap_, header + i);
+ prototype_transitions->set_undefined(header + i);
}
}
=======================================
--- /branches/bleeding_edge/src/objects-inl.h Wed Aug 28 08:39:43 2013 UTC
+++ /branches/bleeding_edge/src/objects-inl.h Wed Aug 28 14:26:22 2013 UTC
@@ -2092,28 +2092,21 @@
void FixedArray::set_undefined(int index) {
- ASSERT(map() != HEAP->fixed_cow_array_map());
- set_undefined(GetHeap(), index);
-}
-
-
-void FixedArray::set_undefined(Heap* heap, int index) {
+ ASSERT(map() != GetHeap()->fixed_cow_array_map());
ASSERT(index >= 0 && index < this->length());
- ASSERT(!heap->InNewSpace(heap->undefined_value()));
- WRITE_FIELD(this, kHeaderSize + index * kPointerSize,
- heap->undefined_value());
+ ASSERT(!GetHeap()->InNewSpace(GetHeap()->undefined_value()));
+ WRITE_FIELD(this,
+ kHeaderSize + index * kPointerSize,
+ GetHeap()->undefined_value());
}
void FixedArray::set_null(int index) {
- set_null(GetHeap(), index);
-}
-
-
-void FixedArray::set_null(Heap* heap, int index) {
ASSERT(index >= 0 && index < this->length());
- ASSERT(!heap->InNewSpace(heap->null_value()));
- WRITE_FIELD(this, kHeaderSize + index * kPointerSize,
heap->null_value());
+ ASSERT(!GetHeap()->InNewSpace(GetHeap()->null_value()));
+ WRITE_FIELD(this,
+ kHeaderSize + index * kPointerSize,
+ GetHeap()->null_value());
}
=======================================
--- /branches/bleeding_edge/src/objects.h Wed Aug 28 08:39:43 2013 UTC
+++ /branches/bleeding_edge/src/objects.h Wed Aug 28 14:26:22 2013 UTC
@@ -2913,11 +2913,7 @@
// Setters for frequently used oddballs located in old space.
inline void set_undefined(int index);
- // TODO(isolates): duplicate.
- inline void set_undefined(Heap* heap, int index);
inline void set_null(int index);
- // TODO(isolates): duplicate.
- inline void set_null(Heap* heap, int index);
inline void set_the_hole(int index);
inline Object** GetFirstElementAddress();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
