On 2013/08/28 14:59:47, Michael Starzinger wrote:
LGTM with one comment in the allocator.
https://codereview.chromium.org/23691002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23691002/diff/1/src/heap.cc#newcode3670
src/heap.cc:3670: entry->set_native_context(native_context,
SKIP_WRITE_BARRIER);
Skipping WBs for all four of these setters is not safe, as any of these
objects
might be on evacuation candidates and the entry itself is not in
new-space.
Good catch. I was originally setting them to Smi 0.
https://codereview.chromium.org/23691002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23691002/diff/1/src/objects.h#newcode6857
src/objects.h:6857: // Entries are cleaned up lazily as each list is
traversed.
nit: s/cleaned up/removed from the list/ IIUC?
Yep.
https://codereview.chromium.org/23691002/diff/1/src/objects.h#newcode6904
src/objects.h:6904: // and code.
nit: ... and literals.
Done.
https://codereview.chromium.org/23691002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
