ok thanks, ptal
https://codereview.chromium.org/23135018/diff/3001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/23135018/diff/3001/src/ia32/lithium-codegen-ia32.cc#newcode1030
src/ia32/lithium-codegen-ia32.cc:1030: if (x87_stack_.depth() > 0 ||
(FLAG_debug_code && FLAG_enable_slow_asserts)) {
On 2013/08/29 08:55:56, Michael Starzinger wrote:
I don't understand why we need to enable flushing when --debug-code is
passed.
Can we drop this?
The idea would have been to verify that the stack is empty at runtime.
Unfortunately this blows up some near-labels by now, since the verify is
like 15 instructions, so i have to drop it for now...
https://codereview.chromium.org/23135018/diff/3001/src/ia32/lithium-codegen-ia32.h
File src/ia32/lithium-codegen-ia32.h (right):
https://codereview.chromium.org/23135018/diff/3001/src/ia32/lithium-codegen-ia32.h#newcode470
src/ia32/lithium-codegen-ia32.h:470: void CommitWrite(X87Register reg);
On 2013/08/29 08:55:56, Michael Starzinger wrote:
I think both, "PrepareToWrite" and "CommitWrite" should also check the
mutability predicate explicitly.
Done.
https://codereview.chromium.org/23135018/diff/3001/src/ia32/lithium-codegen-ia32.h#newcode492
src/ia32/lithium-codegen-ia32.h:492: bool copy_;
On 2013/08/29 08:55:56, Michael Starzinger wrote:
Let's call this "is_mutable_" instead and reverse the semantics. I
think that's
easier to understand. WDYT?
Done.
https://codereview.chromium.org/23135018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
