Revision: 16440
Author: [email protected]
Date: Fri Aug 30 07:48:04 2013 UTC
Log: Assert external strings in external string table. Remove TODOs.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/23567002
http://code.google.com/p/v8/source/detail?r=16440
Modified:
/branches/bleeding_edge/src/heap-inl.h
/branches/bleeding_edge/src/heap.cc
=======================================
--- /branches/bleeding_edge/src/heap-inl.h Wed Aug 21 18:31:13 2013 UTC
+++ /branches/bleeding_edge/src/heap-inl.h Fri Aug 30 07:48:04 2013 UTC
@@ -718,13 +718,11 @@
#ifdef DEBUG
for (int i = 0; i < new_space_strings_.length(); ++i) {
Object* obj = Object::cast(new_space_strings_[i]);
- // TODO(yangguo): check that the object is indeed an external string.
ASSERT(heap_->InNewSpace(obj));
ASSERT(obj != HEAP->the_hole_value());
}
for (int i = 0; i < old_space_strings_.length(); ++i) {
Object* obj = Object::cast(old_space_strings_[i]);
- // TODO(yangguo): check that the object is indeed an external string.
ASSERT(!heap_->InNewSpace(obj));
ASSERT(obj != HEAP->the_hole_value());
}
=======================================
--- /branches/bleeding_edge/src/heap.cc Thu Aug 29 09:58:30 2013 UTC
+++ /branches/bleeding_edge/src/heap.cc Fri Aug 30 07:48:04 2013 UTC
@@ -7916,6 +7916,7 @@
if (new_space_strings_[i] == heap_->the_hole_value()) {
continue;
}
+ ASSERT(new_space_strings_[i]->IsExternalString());
if (heap_->InNewSpace(new_space_strings_[i])) {
new_space_strings_[last++] = new_space_strings_[i];
} else {
@@ -7930,6 +7931,7 @@
if (old_space_strings_[i] == heap_->the_hole_value()) {
continue;
}
+ ASSERT(old_space_strings_[i]->IsExternalString());
ASSERT(!heap_->InNewSpace(old_space_strings_[i]));
old_space_strings_[last++] = old_space_strings_[i];
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
