Reviewers: Benedikt Meurer,
Message:
Benedikt: PTAL.
Bangfu: FYI.
Description:
Revert "ConstantPoolSizeAt() should return number of Instructions instead,
otherwise, some of the code will be treated as constant pool when printing
code
in ARM disassembler."
This reverts commit r16419 for breaking ARM Debug tests.
Please review this at https://codereview.chromium.org/23522006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/disasm-arm.cc
Index: src/arm/disasm-arm.cc
diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc
index
bbddeb25b346a6fd2a167b60d960ab0e6adfcd7d..acffaa3f230ac5fe9fb639a34e0dbec3dc5cdc3c
100644
--- a/src/arm/disasm-arm.cc
+++ b/src/arm/disasm-arm.cc
@@ -1655,7 +1655,7 @@ bool Decoder::IsConstantPoolAt(byte* instr_ptr) {
int Decoder::ConstantPoolSizeAt(byte* instr_ptr) {
if (IsConstantPoolAt(instr_ptr)) {
int instruction_bits = *(reinterpret_cast<int*>(instr_ptr));
- return DecodeConstantPoolLength(instruction_bits) /
Assembler::kInstrSize;
+ return DecodeConstantPoolLength(instruction_bits);
} else {
return -1;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
