LGTM with one nit and one comment.
https://codereview.chromium.org/23707007/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23707007/diff/1/src/objects.cc#newcode3655
src/objects.cc:3655: void JSProxy::Fix(Handle<JSProxy> self) {
nit: s/self/proxy here for consistency.
https://codereview.chromium.org/23707007/diff/1/src/objects.cc#newcode3671
src/objects.cc:3671: Handle<JSObject> new_self(JSObject::cast(*self));
This re-handlification of "self" makes no sense to me, let's drop it.
https://codereview.chromium.org/23707007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
