High-level:
(1) I'd prefer this extra field to be in the SharedFunctionInfo, as we have
many
Code objects that don't need it, and Code object header size is fairly
sensitive
as the entry offset must be aligned (at least 16-byte, I think).
(2) Shouldn't we call the thing interrupt_budget?
https://codereview.chromium.org/23747003/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/23747003/diff/1/src/full-codegen.cc#newcode439
src/full-codegen.cc:439: ASSERT(!profiling_budget_.is_null());
No need for this ASSERT, you get it for free as part of the deref below.
https://codereview.chromium.org/23747003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
