On 2013/08/30 10:34:48, Jakob wrote:
AstTyper::VisitStatements() contains the optimization "if (stmt->IsJump())
break;". Other AstVisitors, in particular the HOptimizedGraphBuilder,
must do
the same, or they will stumble over uninitialized type feedback (empty
handles)
in nodes that the typer has skipped.
An alternative implementation would be to remove the early return from the
AstTyper, but I think it's a valid optimization, so we should just do it
everywhere.
LGTM too. Thanks for fixing.
Ideally, we should really only have one implementation of
VisitStatements/Declarations and the CHECK macros that works for all
visitors.
Maybe I'll try to refactor that.
https://codereview.chromium.org/23441018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
