Reviewers: Benedikt Meurer,
Message:
On 2013/08/30 07:31:32, Benedikt Meurer wrote:
Your patch broke the ARM tests, we had to revert. Please submit a new
patch
that
actually passes the test suite.
Sorry about that, we did not realize the bug had been fixed in the latest
bleeding edge.
Description:
ConstantPoolSizeAt() should return number of Instructions instead,
otherwise,
some of the code will be treated as constant pool when printing code in ARM
disassembler.
BUG=none
TEST=none
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=16419
Please review this at https://codereview.chromium.org/23654005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/disasm-arm.cc
Index: src/arm/disasm-arm.cc
diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc
index
ecdf638a1da36fafa12812c347e35cda684d8210..6c54489e82efdc3b7c8a6d7fddd55e43d1d3ddf5
100644
--- a/src/arm/disasm-arm.cc
+++ b/src/arm/disasm-arm.cc
@@ -1658,7 +1658,7 @@ bool Decoder::IsConstantPoolAt(byte* instr_ptr) {
int Decoder::ConstantPoolSizeAt(byte* instr_ptr) {
if (IsConstantPoolAt(instr_ptr)) {
int instruction_bits = *(reinterpret_cast<int*>(instr_ptr));
- return DecodeConstantPoolLength(instruction_bits);
+ return DecodeConstantPoolLength(instruction_bits) /
Assembler::kInstrSize;
} else {
return -1;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
