If I understand correctly, this CL is functionally equivalent to:
#if V8_TARGET_ARCH_X64
static const int kInitialMaxFastElementArray = 98297;
#else
static const int kInitialMaxFastElementArray = 100000;
#endif
Right?
While a computed value is arguably cleaner (and more robust towards
potential
future target architectures) than an #if, I'm still not sure it's the best
solution here. Since fast vs. dictionary elements can have a significant
impact
on performance, it would be quite surprising to have different behavior on
different platforms.
Since the limit we're hitting is kind of arbitrary anyway, how about simply
bumping that a bit? See https://codereview.chromium.org/23604023 for what I
mean.
https://codereview.chromium.org/23622016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
