LGTM with comment.
https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h
File src/objects-inl.h (right):
https://chromiumcodereview.appspot.com/23453019/diff/2001/src/objects-inl.h#newcode2652
src/objects-inl.h:2652: static bool IsIdentifier(UnicodeCache* cache,
Name* name) {
This seems a little large for -inl.h. Please move it to objects.cc (and
Name::IsCacheable with it). You could also consider making it a method
of Name.
https://chromiumcodereview.appspot.com/23453019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
