Thanks for the review, landing.
https://codereview.chromium.org/23604023/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode195
src/heap.cc:195: ASSERT(MaxRegularSpaceAllocationSize() >=
On 2013/09/02 13:12:43, Michael Starzinger wrote:
The initial_semispace_size might change at runtime, so this assert
should go at
the end of Heap::ConfigureHeap I think.
Good point. Done.
https://codereview.chromium.org/23604023/diff/1/src/heap.cc#newcode198
src/heap.cc:198: JSObject::kInitialMaxFastElementArray * kPointerSize +
On 2013/09/02 13:12:43, Michael Starzinger wrote:
nit: Lets use FixedArray::SizeFor for (part of) this calculation.
Done.
https://codereview.chromium.org/23604023/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
