https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h#newcode63
include/v8-profiler.h:63: Handle<String> GetBailoutReason() const;
Can we start returning const char* instead of JS strings?
https://codereview.chromium.org/23817003/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/23817003/diff/1/src/ast.h#newcode2316
src/ast.h:2316: inline BailoutReason dont_optimize_reason() {
No need to add inline, the compiler should be smart enough to figure
that out.
https://codereview.chromium.org/23817003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23817003/diff/1/src/objects.h#newcode1335
src/objects.h:1335: V(kYield, "Yeld")
\
No need in \ after the last line
https://codereview.chromium.org/23817003/diff/1/src/objects.h#newcode6601
src/objects.h:6601: inline void set_bailout_reason(BailoutReason reason)
{
excessive 'inline'
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc
File test/cctest/test-profile-generator.cc (right):
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc#newcode802
test/cctest/test-profile-generator.cc:802: "function kTryFinally() {\n"
Why this "k" prefix?
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc#newcode821
test/cctest/test-profile-generator.cc:821: // startProfiling
There should always be that tick as we generate it from startProfiling
or am I missing something?
https://codereview.chromium.org/23817003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
