Reviewers: Yury Semikhatsky,
Message:
comments addressed
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/23817003/diff/1/include/v8-profiler.h#newcode63
include/v8-profiler.h:63: Handle<String> GetBailoutReason() const;
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
Can we start returning const char* instead of JS strings?
Done.
https://codereview.chromium.org/23817003/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/23817003/diff/1/src/ast.h#newcode2316
src/ast.h:2316: inline BailoutReason dont_optimize_reason() {
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
No need to add inline, the compiler should be smart enough to figure
that out.
Done.
https://codereview.chromium.org/23817003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23817003/diff/1/src/objects.h#newcode1335
src/objects.h:1335: V(kYield, "Yeld")
\
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
No need in \ after the last line
Done.
https://codereview.chromium.org/23817003/diff/1/src/objects.h#newcode6601
src/objects.h:6601: inline void set_bailout_reason(BailoutReason reason)
{
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
excessive 'inline'
Done.
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc
File test/cctest/test-profile-generator.cc (right):
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc#newcode802
test/cctest/test-profile-generator.cc:802: "function kTryFinally() {\n"
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
Why this "k" prefix?
Done.
https://codereview.chromium.org/23817003/diff/1/test/cctest/test-profile-generator.cc#newcode821
test/cctest/test-profile-generator.cc:821: // startProfiling
On 2013/09/02 14:40:05, Yury Semikhatsky wrote:
There should always be that tick as we generate it from startProfiling
or am I
missing something?
Done.
Description:
Functions may not be optimized and we would like to know in cpu profiler
what
was the reason.
Current v8 implementation may disable optimization for a particular
function or
block it with help of dont_optimize flag.
The patch propagates the reason of that to the SharedFunctionInfo where cpu
profiler can get it.
SharedFunctionInfo is a heap object so I extracted 8 bits from OptsCount for
handling bailout reason code.
BUG=none
TEST=test-profile-generator/BailoutReason
Please review this at https://codereview.chromium.org/23817003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8-profiler.h
M src/api.cc
M src/ast.h
M src/ast.cc
M src/compiler.cc
M src/cpu-profiler.cc
M src/full-codegen.cc
M src/heap.cc
M src/hydrogen.cc
M src/objects-inl.h
M src/objects.h
M src/objects.cc
M src/parser.cc
M src/profile-generator-inl.h
M src/profile-generator.h
M src/profile-generator.cc
M test/cctest/test-profile-generator.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
