Revision: 16488
Author: [email protected]
Date: Mon Sep 2 17:06:08 2013 UTC
Log: Remove obsolete global V8::IsRunning() predicate.
[email protected]
BUG=v8:2744
Review URL: https://codereview.chromium.org/23597013
http://code.google.com/p/v8/source/detail?r=16488
Modified:
/branches/bleeding_edge/src/bootstrapper.cc
/branches/bleeding_edge/src/v8.cc
/branches/bleeding_edge/src/v8.h
/branches/bleeding_edge/test/cctest/test-log.cc
=======================================
--- /branches/bleeding_edge/src/bootstrapper.cc Mon Aug 26 17:00:58 2013 UTC
+++ /branches/bleeding_edge/src/bootstrapper.cc Mon Sep 2 17:06:08 2013 UTC
@@ -2588,8 +2588,8 @@
: isolate_(isolate),
active_(isolate->bootstrapper()) {
result_ = Handle<Context>::null();
- // If V8 isn't running and cannot be initialized, just return.
- if (!V8::IsRunning() && !V8::Initialize(NULL)) return;
+ // If V8 cannot be initialized, just return.
+ if (!V8::Initialize(NULL)) return;
// Before creating the roots we must save the context and restore it
// on all function exits.
=======================================
--- /branches/bleeding_edge/src/v8.cc Thu Aug 29 09:58:30 2013 UTC
+++ /branches/bleeding_edge/src/v8.cc Mon Sep 2 17:06:08 2013 UTC
@@ -50,7 +50,6 @@
V8_DECLARE_ONCE(init_once);
-bool V8::is_running_ = false;
bool V8::has_been_set_up_ = false;
bool V8::has_been_disposed_ = false;
bool V8::has_fatal_error_ = false;
@@ -85,7 +84,6 @@
Isolate* isolate = Isolate::Current();
if (isolate->IsInitialized()) return true;
- is_running_ = true;
has_been_set_up_ = true;
has_fatal_error_ = false;
has_been_disposed_ = false;
@@ -95,7 +93,6 @@
void V8::SetFatalError() {
- is_running_ = false;
has_fatal_error_ = true;
}
@@ -118,7 +115,6 @@
RegisteredExtension::UnregisterAll();
Isolate::GlobalTearDown();
- is_running_ = false;
has_been_disposed_ = true;
delete call_completed_callbacks_;
=======================================
--- /branches/bleeding_edge/src/v8.h Thu Jul 4 16:32:12 2013 UTC
+++ /branches/bleeding_edge/src/v8.h Mon Sep 2 17:06:08 2013 UTC
@@ -82,7 +82,6 @@
// empty heap.
static bool Initialize(Deserializer* des);
static void TearDown();
- static bool IsRunning() { return is_running_; }
static bool UseCrankshaft() { return use_crankshaft_; }
// To be dead you have to have lived
// TODO(isolates): move IsDead to Isolate.
@@ -131,8 +130,6 @@
static void InitializeOncePerProcessImpl();
static void InitializeOncePerProcess();
- // True if engine is currently running
- static bool is_running_;
// True if V8 has ever been run
static bool has_been_set_up_;
// True if error has been signaled for current engine
=======================================
--- /branches/bleeding_edge/test/cctest/test-log.cc Mon Sep 2 12:26:06
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-log.cc Mon Sep 2 17:06:08
2013 UTC
@@ -427,9 +427,6 @@
// it launches a new cctest instance for every test. To be sure that
launching
// cctest manually also works, please be sure that no tests below
// are using V8.
- //
- // P.S. No, V8 can't be re-initialized after disposal, see include/v8.h.
- CHECK(!i::V8::IsRunning());
// Start with profiling to capture all code events from the beginning.
ScopedLoggerInitializer initialize_logger;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
