LGTM if all comments are addressed.
https://codereview.chromium.org/23548007/diff/2001/src/platform/mutex.h
File src/platform/mutex.h (right):
https://codereview.chromium.org/23548007/diff/2001/src/platform/mutex.h#newcode44
src/platform/mutex.h:44: class ConditionVariable;
There should be no need to forward declare this if it is only used to
declare a friend.
https://codereview.chromium.org/23548007/diff/2001/src/platform/mutex.h#newcode100
src/platform/mutex.h:100: V8_INLINE(void CheckHeldAndUnmark()) {
nit: s/Check/Assert/, we use "check" to describe predicates that are
also validated in release builds, this will only be validated in debug
builds.
https://codereview.chromium.org/23548007/diff/2001/src/platform/mutex.h#newcode107
src/platform/mutex.h:107: V8_INLINE(void CheckUnheldAndMark()) {
Likewise.
https://codereview.chromium.org/23548007/diff/2001/src/x64/disasm-x64.cc
File src/x64/disasm-x64.cc (right):
https://codereview.chromium.org/23548007/diff/2001/src/x64/disasm-x64.cc#newcode336
src/x64/disasm-x64.cc:336: kWordSize = 1,
nit: This makes it look like these are constants that actually specify
the size in bytes, which is not the case, as they are just enums. Can we
instead call them OPERAND_BYTE_SIZE, OPERAND_WORD_SIZE and so on?
https://codereview.chromium.org/23548007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
