https://codereview.chromium.org/23886002/diff/4001/src/heap-snapshot-generator.h
File src/heap-snapshot-generator.h (right):
https://codereview.chromium.org/23886002/diff/4001/src/heap-snapshot-generator.h#newcode418
src/heap-snapshot-generator.h:418: V8HeapExplorer(Heap* heap,
I don't think we need this: A HeapSnapshot has a HeapSnapshotCollection,
and the from there you can get a Heap. I propose to add a heap() method
to HeapSnapshot to avoid a "train wreck".
https://codereview.chromium.org/23886002/diff/4001/src/heap-snapshot-generator.h#newcode541
src/heap-snapshot-generator.h:541: NativeObjectsExplorer(Isolate*
isolate,
Basically the same holds here.
https://codereview.chromium.org/23886002/diff/4001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/23886002/diff/4001/src/isolate.h#newcode1388
src/isolate.h:1388: if (context_.is_null()) {
Slightly clearer:
isolate_->set_context(context_.is_null() ? NULL : *context);
https://codereview.chromium.org/23886002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
