LGTM with a nit
https://codereview.chromium.org/23549011/diff/1/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/23549011/diff/1/src/serialize.h#newcode477
src/serialize.h:477: Isolate* isolate() { return isolate_; }
const
https://codereview.chromium.org/23549011/diff/1/src/v8threads.cc
File src/v8threads.cc (right):
https://codereview.chromium.org/23549011/diff/1/src/v8threads.cc#newcode148
src/v8threads.cc:148: i::Isolate::Current(), every_n_ms);
Hmmm, we'll have to think about these: The Locker is constructed with a
given Isolate, and I'm currently not 100% sure if this is the same as
Current(). But this doesn't change the current behavior, so let's defer
this...
https://codereview.chromium.org/23549011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
