CC'ing Sven for additional feedback.
The patch looks good so far, however:
(1) While we are at it: Wouldn't it be faster to compute src + length in the
length register on startup, yiedling send, and afterwards just compare src
and
send, so you don't need to increment src and decrement length? That'd at
least
save a few instructions.
(2) Please add a test case for the function.
https://codereview.chromium.org/23480027/diff/3001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/23480027/diff/3001/src/arm/macro-assembler-arm.cc#newcode3194
src/arm/macro-assembler-arm.cc:3194:
Please add ASSERTs that src, dst, length and scratch are distinct
registers.
https://codereview.chromium.org/23480027/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
