On 2013/09/04 06:50:16, Sven Panne wrote:
On 2013/09/03 19:36:34, tfarina wrote:
> https://codereview.chromium.org/23484014/diff/7001/src/platform.h
> File src/platform.h (right):
>
>
https://codereview.chromium.org/23484014/diff/7001/src/platform.h#newcode411
> src/platform.h:411: class VirtualMemory {
> is the goal to move all these classes into their separate headers? Are
you
going
> to move VirtualMemory and Thread next, to src/platform/?
I don't think we have a detailed plan which class comes next, but in
general:
Yes. Instead of the fundamentally broken platform-foo.* mess, we move to
the
usual autoconf-style way of handling platform dependencies via feature
#defines/#ifs.
VirtualMemory is next. :-)
That this is a lessons learned by almost all projects, even if it
sometimes
takes decades: http://en.wikipedia.org/wiki/Imake ;-)
Well it's no necessarily autotools-style. With autotools, I used to split
stuff
into separate platform files usually (i.e. file.h, file.c, file-win.c,
file-unix.c), but since GYP is far from autotools/cmake/whatever, we'll
have to
live with the since .cc file approach. Given our usually small platform
classes,
this is not a big issue.
https://codereview.chromium.org/23484014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
