Reviewers: loislo, Jakob, Sven Panne,
Description:
Use 1ms CPU profiler sampling interval on Android by default
This CL changes default sampling interval on Android from 5ms to 1ms so
that it
is the same on all platforms. All perf tests on modern devices (Galaxy
Nexus,
Nexus 7) show that 1ms should be long enough for profiling on mobile
devices.
BUG=None
Please review this at https://codereview.chromium.org/23927005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
f19c4a6759ce44919aa12bfaec67f4e1b125cc4f..6ab5aeb2680f936a55f8ade25049934e632886cd
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -455,16 +455,8 @@ DEFINE_bool(compilation_cache, true, "enable
compilation cache")
DEFINE_bool(cache_prototype_transitions, true, "cache prototype
transitions")
// cpu-profiler.cc
-#if defined(ANDROID)
-// Phones and tablets have processors that are much slower than desktop
-// and laptop computers for which current heuristics are tuned.
-#define DEFAULT_INTERVAL 5000
-#else
-#define DEFAULT_INTERVAL 1000
-#endif
-DEFINE_int(cpu_profiler_sampling_interval, DEFAULT_INTERVAL,
+DEFINE_int(cpu_profiler_sampling_interval, 1000,
"CPU profiler sampling interval in microseconds")
-#undef DEFAULT_INTERVAL
// debug.cc
DEFINE_bool(trace_debug_json, false, "trace debugging JSON
request/response")
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
