On 2013/09/04 14:35:36, loislo wrote:
lgtm with nits
https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc#newcode117
src/cpu-profiler.cc:117: const TickSampleEventRecord* record =
ticks_buffer_.StartDequeue();
please rename StartDequeue to peek and FinishDequeue to remove as like as
in
java queue interface.
in a separate patch
https://codereview.chromium.org/23583036/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
