LGTM if comments are addressed.
Also test cases where the getter and setter functions have signatures would
be
helpful!
https://codereview.chromium.org/23699002/diff/7001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/23699002/diff/7001/src/ia32/stub-cache-ia32.cc#newcode1366
src/ia32/stub-cache-ia32.cc:1366: // assign stack space for the call
arguments
nit: Capitalize and punctuate comments.
https://codereview.chromium.org/23699002/diff/7001/src/ia32/stub-cache-ia32.cc#newcode1375
src/ia32/stub-cache-ia32.cc:1375:
call_optimization.expected_receiver_type().is_null() ?
We should just always use receiver() here, because either the expected
receiver type is null or the first compatible object is in receiver().
Using "reg" here is never what we intend it to be. This applies to all
architectures.
https://codereview.chromium.org/23699002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
