LGTM if all comments are addressed.
https://codereview.chromium.org/23903008/diff/1/src/platform-linux.cc
File src/platform-linux.cc (left):
https://codereview.chromium.org/23903008/diff/1/src/platform-linux.cc#oldcode508
src/platform-linux.cc:508: void OS::TearDown() {
AFAICT, this makes OS::TearDown empty on all platforms. Let's drop it
completely.
https://codereview.chromium.org/23903008/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/23903008/diff/1/src/spaces.cc#newcode315
src/spaces.cc:315: UpdateAllocatedSpaceLimits(base,
reinterpret_cast<char*>(base) + size);
No need for a reinterpret_cast here, our Address typedef should allow
for byte-based arithmetic.
https://codereview.chromium.org/23903008/diff/1/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/23903008/diff/1/src/spaces.h#newcode1091
src/spaces.h:1091: return false;
This looks like debugging leftovers. Let's use the real boundary check
as a return value.
https://codereview.chromium.org/23903008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
