Reviewers: Toon Verwaest,
Description:
Consistently use CHECK_ALIVE_OR_RETURN in graph builder.
[email protected]
Please review this at https://codereview.chromium.org/23819026/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -6 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
25522e87ec0b128fd4f020486e4fbb06c5162a8a..6e072450066db2fadf344f4ec4f222191874bcea
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5797,8 +5797,7 @@ bool
HOptimizedGraphBuilder::TryArgumentsAccess(Property* expr) {
}
} else {
Push(graph()->GetArgumentsObject());
- VisitForValue(expr->key());
- if (HasStackOverflow() || current_block() == NULL) return true;
+ CHECK_ALIVE_OR_RETURN(VisitForValue(expr->key()), true);
HValue* key = Pop();
Drop(1); // Arguments object.
if (function_state()->outer() == NULL) {
@@ -6866,14 +6865,12 @@ bool HOptimizedGraphBuilder::TryCallApply(Call*
expr) {
if (!arg_two_value->CheckFlag(HValue::kIsArguments)) return false;
// Found pattern f.apply(receiver, arguments).
- VisitForValue(prop->obj());
- if (HasStackOverflow() || current_block() == NULL) return true;
+ CHECK_ALIVE_OR_RETURN(VisitForValue(prop->obj()), true);
HValue* function = Top();
AddCheckConstantFunction(expr->holder(), function, function_map);
Drop(1);
- VisitForValue(args->at(0));
- if (HasStackOverflow() || current_block() == NULL) return true;
+ CHECK_ALIVE_OR_RETURN(VisitForValue(args->at(0)), true);
HValue* receiver = Pop();
if (function_state()->outer() == NULL) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
