Not quite done yet. First round of comments. I'll continue tomorrow.
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js#newcode960
src/debug-debugger.js:960: ExecutionState.prototype.prepareStep =
function(opt_action, opt_count, opt_callframe) {
80 char limit.
https://codereview.chromium.org/23533015/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/23533015/diff/1/src/debug.cc#newcode1380
src/debug.cc:1380: StackFrame::Id frame_id) {
same here, just put one argument per line.
https://codereview.chromium.org/23533015/diff/1/src/debug.h
File src/debug.h (right):
https://codereview.chromium.org/23533015/diff/1/src/debug.h#newcode263
src/debug.h:263: StackFrame::Id frame_id);
just put one argument per line please.
https://codereview.chromium.org/23533015/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/23533015/diff/1/src/runtime.cc#newcode12583
src/runtime.cc:12583: if (frame_id != 0 && step_action != StepNext &&
step_action != StepMin &&
probably better to compare frame_id to StackFrame::NO_ID and not the
constant value behind it.
https://codereview.chromium.org/23533015/diff/1/src/runtime.cc#newcode12599
src/runtime.cc:12599: step_count, frame_id);
put frame_id on a new line or all arguments on the second line for
consistent formatting.
https://codereview.chromium.org/23533015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
