Revision: 16562
Author:   [email protected]
Date:     Thu Sep  5 18:41:20 2013 UTC
Log:      Consistently use CHECK_ALIVE_OR_RETURN in graph builder.

[email protected]

Review URL: https://codereview.chromium.org/23819026
http://code.google.com/p/v8/source/detail?r=16562

Modified:
 /branches/bleeding_edge/src/hydrogen.cc

=======================================
--- /branches/bleeding_edge/src/hydrogen.cc     Thu Sep  5 16:22:46 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc     Thu Sep  5 18:41:20 2013 UTC
@@ -5796,8 +5796,7 @@
     }
   } else {
     Push(graph()->GetArgumentsObject());
-    VisitForValue(expr->key());
-    if (HasStackOverflow() || current_block() == NULL) return true;
+    CHECK_ALIVE_OR_RETURN(VisitForValue(expr->key()), true);
     HValue* key = Pop();
     Drop(1);  // Arguments object.
     if (function_state()->outer() == NULL) {
@@ -6865,14 +6864,12 @@
   if (!arg_two_value->CheckFlag(HValue::kIsArguments)) return false;

   // Found pattern f.apply(receiver, arguments).
-  VisitForValue(prop->obj());
-  if (HasStackOverflow() || current_block() == NULL) return true;
+  CHECK_ALIVE_OR_RETURN(VisitForValue(prop->obj()), true);
   HValue* function = Top();
   AddCheckConstantFunction(expr->holder(), function, function_map);
   Drop(1);

-  VisitForValue(args->at(0));
-  if (HasStackOverflow() || current_block() == NULL) return true;
+  CHECK_ALIVE_OR_RETURN(VisitForValue(args->at(0)), true);
   HValue* receiver = Pop();

   if (function_state()->outer() == NULL) {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to