Addressed comments, PTAL again.
https://chromiumcodereview.appspot.com/23615012/diff/1/src/ast.h
File src/ast.h (right):
https://chromiumcodereview.appspot.com/23615012/diff/1/src/ast.h#newcode291
src/ast.h:291: void FilterForPossibleTransitions(Map* root_map, Zone*
zone) {
On 2013/09/05 20:07:23, Michael Starzinger wrote:
The "zone" parameter is obsolete, as we only remove elements with this
method
and don't add new ones.
Done.
https://chromiumcodereview.appspot.com/23615012/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/23615012/diff/1/src/hydrogen.cc#newcode5706
src/hydrogen.cc:5706: if (types != NULL &&
obj->HasMonomorphicJSObjectType()) {
On 2013/09/05 20:07:23, Michael Starzinger wrote:
suggestion: Does it make sense to factor this out into a static helper
method
that computes the receiver types for us? I was thinking along the
lines of a
method with either of the following signatures (I prefer the first
one)...
// Return true if receiver is monomorphic.
static bool ComputeReceiverTypes(Expression* expr,
Object* receiver,
SmallMapList** types);
static SmallMapList* ComputeReceiverTypes(Expression* expr,
Object* receiver,
bool* monomorphic);
Done.
https://chromiumcodereview.appspot.com/23615012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
