https://chromiumcodereview.appspot.com/23561007/diff/1/src/apinatives.js
File src/apinatives.js (right):
https://chromiumcodereview.appspot.com/23561007/diff/1/src/apinatives.js#newcode40
src/apinatives.js:40: var kApiFunctionCache = new InternalArray();
On 2013/09/06 15:39:12, yhirano wrote:
I think we should use Object here because serial_number can grow to a
very large
number by repetitive Function::New calls.
okay, i can just set the serial_number for objects that aren't going to
be cached to be 0 or -1 or something, then we won't have a problem
https://chromiumcodereview.appspot.com/23561007/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://chromiumcodereview.appspot.com/23561007/diff/1/test/cctest/test-api.cc#newcode20523
test/cctest/test-api.cc:20523: #endif // V8_OS_POSIX
On 2013/09/06 14:41:50, Michael Starzinger wrote:
I think this #endif was already misplaced before.
when i see a 20,000 line file, I just stick new code at the bottom, and
90% I'm right
https://chromiumcodereview.appspot.com/23561007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
