Reviewers: Benedikt Meurer,
Message:
Is this fine? I know it is a one-off, so it might not be accepted.
Thanks for your time in reviewing this in advance.
Thanks,
Description:
Replace uses of MUST_USE_RESULT by V8_WARN_UNUSED_RESULT in ElapsedTimer.
BUG=None
TEST=none, no functional changes.
[email protected]
Signed-off-by: Thiago Farina <[email protected]>
Please review this at https://codereview.chromium.org/23523034/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+3, -3 lines):
M src/platform/elapsed-timer.h
Index: src/platform/elapsed-timer.h
diff --git a/src/platform/elapsed-timer.h b/src/platform/elapsed-timer.h
index
e5bcf232f384348258eec5c7a239ce3ec148b007..773abbc8aacc8b1096fd00a06f1a5743c5fb88fd
100644
--- a/src/platform/elapsed-timer.h
+++ b/src/platform/elapsed-timer.h
@@ -87,7 +87,7 @@ class ElapsedTimer V8_FINAL BASE_EMBEDDED {
// Returns the time elapsed since the previous start. This method may
only
// be called on a previously started timer.
- MUST_USE_RESULT TimeDelta Elapsed() const {
+ TimeDelta Elapsed() const V8_WARN_UNUSED_RESULT {
ASSERT(IsStarted());
TimeDelta elapsed = Now() - start_ticks_;
ASSERT(elapsed.InMicroseconds() >= 0);
@@ -97,13 +97,13 @@ class ElapsedTimer V8_FINAL BASE_EMBEDDED {
// Returns |true| if the specified |time_delta| has elapsed since the
// previous start, or |false| if not. This method may only be called on
// a previously started timer.
- MUST_USE_RESULT bool HasExpired(TimeDelta time_delta) const {
+ bool HasExpired(TimeDelta time_delta) const V8_WARN_UNUSED_RESULT {
ASSERT(IsStarted());
return Elapsed() >= time_delta;
}
private:
- MUST_USE_RESULT V8_INLINE(static TimeTicks Now()) {
+ V8_INLINE(static TimeTicks Now()) V8_WARN_UNUSED_RESULT {
TimeTicks now = TimeTicks::HighResNow();
ASSERT(!now.IsNull());
return now;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
