Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as r16590.
Description:
temporarily remove persistent destructor to allow trunk push
[email protected]
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16590
Please review this at https://codereview.chromium.org/24023004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -4 lines):
M include/v8.h
M test/cctest/test-api.cc
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
004420c11d3670943574e159c4171eb5731e2c8a..11aa47394f55d63711b93708c6ff7252a8f651bf
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -549,9 +549,9 @@ template <class T, class M> class Persistent {
* kResetInDestructor flags in the traits class. Since not calling
dispose
* can result in a memory leak, it is recommended to always set this
flag.
*/
- V8_INLINE(~Persistent()) {
- if (M::kResetInDestructor) Reset();
- }
+// V8_INLINE(~Persistent()) {
+// if (M::kResetInDestructor) Reset();
+// }
/**
* If non-empty, destroy the underlying storage cell
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
19f33095ffd41b0968d85c1cd31ab8f5a7d03628..aaac4866324777940b3c7c920be68ec35382e3ee
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -12700,7 +12700,7 @@ TEST(CopyablePersistent) {
CHECK_EQ(initial_handles + 3, globals->global_handles_count());
}
// Verify autodispose
- CHECK_EQ(initial_handles, globals->global_handles_count());
+// CHECK_EQ(initial_handles, globals->global_handles_count());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
