On 2013/09/09 07:40:39, Sven Panne wrote:
Hmmm, actually I would prefer PAGE_NOACCESS, too. MSDN explicitly
describes
PAGE_GUARD as a mechanism for growable data structures, e.g.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366549%28v=vs.85%29.aspx.
Therefore I think it is a terrible idea to use this for security, this is
exactly what PAGE_NOACCESS is for. It is very weird that we depend on the
embedder's handling of PAGE_GUARD, consider e.g. using v8 from another
language
implementation (Haskell, OCaml, etc.) where stacks grown on demand via
PAGE_GUARD. Furthermore I would really like to know how much information
we
actually gather from the crash dumps because of PAGE_GUARD: I am not
aware of
any bug report/issue mentioning this in the last years. I doubt that the
trouble
of a weird use of page flags is paying off, it can only detect a tiny
fraction
of bugs/security issues, and I am not convinced why these kind of issues
should
be more important than others.
SOunds good. I am fine with changing this to PAGE_NOACCESS. Thanks guys
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
