Revision: 16605
Author: [email protected]
Date: Tue Sep 10 06:43:23 2013 UTC
Log: Remove HandleScope default ctor.
BUG=chromium:236173
[email protected], [email protected]
Review URL: https://codereview.chromium.org/23530045
Patch from Marja Hölttä <[email protected]>.
http://code.google.com/p/v8/source/detail?r=16605
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/test/cctest/test-heap.cc
/branches/bleeding_edge/test/cctest/test-mark-compact.cc
/branches/bleeding_edge/test/cctest/test-thread-termination.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Mon Sep 9 10:26:25 2013 UTC
+++ /branches/bleeding_edge/include/v8.h Tue Sep 10 06:43:23 2013 UTC
@@ -748,9 +748,6 @@
*/
class V8_EXPORT HandleScope {
public:
- // TODO(svenpanne) Deprecate me when Chrome is fixed!
- HandleScope();
-
HandleScope(Isolate* isolate);
~HandleScope();
=======================================
--- /branches/bleeding_edge/src/api.cc Mon Sep 9 09:25:23 2013 UTC
+++ /branches/bleeding_edge/src/api.cc Tue Sep 10 06:43:23 2013 UTC
@@ -706,11 +706,6 @@
// --- H a n d l e s ---
-HandleScope::HandleScope() {
- Initialize(reinterpret_cast<Isolate*>(i::Isolate::Current()));
-}
-
-
HandleScope::HandleScope(Isolate* isolate) {
Initialize(isolate);
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Wed Sep 4 07:05:11
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-heap.cc Tue Sep 10 06:43:23
2013 UTC
@@ -3422,7 +3422,7 @@
CcTest::InitializeVM();
Isolate* isolate = Isolate::Current();
Heap* heap = isolate->heap();
- v8::HandleScope scope;
+ v8::HandleScope scope(reinterpret_cast<v8::Isolate*>(isolate));
v8::ImplementationUtilities::HandleScopeData* data =
isolate->handle_scope_data();
Handle<Object> init(heap->empty_string(), isolate);
=======================================
--- /branches/bleeding_edge/test/cctest/test-mark-compact.cc Tue Sep 3
07:34:34 2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-mark-compact.cc Tue Sep 10
06:43:23 2013 UTC
@@ -572,7 +572,7 @@
v8::Isolate* isolate = v8::Isolate::New();
{ v8::Isolate::Scope isolate_scope(isolate);
v8::Locker lock(isolate);
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
CHECK(!context.IsEmpty());
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-thread-termination.cc Fri Sep
6 11:29:13 2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-thread-termination.cc Tue Sep
10 06:43:23 2013 UTC
@@ -324,11 +324,11 @@
// Test that a single thread of JavaScript execution can terminate
// itself and then resume execution.
TEST(TerminateCancelTerminateFromThreadItself) {
- v8::HandleScope scope;
+ v8::Isolate* isolate = v8::Isolate::GetCurrent();
+ v8::HandleScope scope(isolate);
v8::Handle<v8::ObjectTemplate> global =
CreateGlobalTemplate(TerminateCurrentThread, DoLoopCancelTerminate);
- v8::Handle<v8::Context> context =
- v8::Context::New(v8::Isolate::GetCurrent(), NULL, global);
+ v8::Handle<v8::Context> context = v8::Context::New(isolate, NULL,
global);
v8::Context::Scope context_scope(context);
CHECK(!v8::V8::IsExecutionTerminating());
v8::Handle<v8::String> source =
@@ -336,4 +336,3 @@
// Check that execution completed with correct return value.
CHECK(v8::Script::Compile(source)->Run()->Equals(v8_str("completed")));
}
-
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
