LGTM with nits.
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc
File src/arm/regexp-macro-assembler-arm.cc (right):
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc#newcode1067
src/arm/regexp-macro-assembler-arm.cc:1067: if (stack_alignment <
kPointerSize) stack_alignment = kPointerSize;
Nit: I think we should simply ASSERT(IsAligned(stack_alignment,
kPointerSize)) here. Otherwise to be 100% correct, we would have to make
sure that kPointerSize is a multiple of stack_alignment.
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc#newcode1082
src/arm/regexp-macro-assembler-arm.cc:1082: if
(OS::ActivationFrameAlignment() != 0) {
Nit: We can also safely assert that the stack_alignment is never 0.
https://codereview.chromium.org/23468015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
