LGTM with nits.
https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h#newcode617
src/heap-inl.h:617: if (FLAG_gc_greedy)
ISOLATE->heap()->GarbageCollectionGreedyCheck()
Wrap argument in ()
https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h#newcode648
src/heap-inl.h:648:
ISOLATE->counters()->gc_last_resort_from_handles()->Increment();
\
... and we should probably wrap () around ISOLATE in this macro, too.
https://codereview.chromium.org/23708030/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23708030/diff/1/src/heap.cc#newcode734
src/heap.cc:734: ASSERT(array->map() != this->fixed_cow_array_map());
Why do we need "this->"?
https://codereview.chromium.org/23708030/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
