Reviewers: Toon Verwaest,
Message:
Hey Toon,
Here's the VirtualMemory refactoring, as promised. :-)
Mostly mechanical, PTAL.
-- Benedikt
Description:
Refactor and cleanup VirtualMemory.
Remove a lot of platform duplication, and simplify the virtual
memory implementation. Also improve readability by avoiding bool
parameters for executability (use a dedicated Executability type
instead).
Get rid of the Isolate::UncheckedCurrent() call in the platform
code, as part of the Isolate TLS cleanup.
Use a dedicated random number generator for the address
randomization, instead of messing with the per-isolate random
number generators.
TEST=cctest/test-virtual-memory
Please review this at https://codereview.chromium.org/23641009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1195, -1829 lines):
M include/v8config.h
M src/arm/codegen-arm.cc
M src/deoptimizer.cc
M src/heap-inl.h
M src/heap.cc
M src/ia32/codegen-ia32.cc
M src/incremental-marking.cc
M src/mips/codegen-mips.cc
M src/platform-cygwin.cc
M src/platform-freebsd.cc
M src/platform-linux.cc
M src/platform-macos.cc
M src/platform-openbsd.cc
M src/platform-posix.cc
M src/platform-solaris.cc
M src/platform-win32.cc
M src/platform.h
A src/platform/virtual-memory.h
A src/platform/virtual-memory.cc
M src/spaces-inl.h
M src/spaces.h
M src/spaces.cc
M src/store-buffer.cc
M src/v8globals.h
M src/x64/codegen-x64.cc
M test/cctest/cctest.gyp
M test/cctest/test-assembler-x64.cc
M test/cctest/test-code-stubs-arm.cc
M test/cctest/test-code-stubs-ia32.cc
M test/cctest/test-code-stubs-x64.cc
M test/cctest/test-macro-assembler-x64.cc
M test/cctest/test-platform-linux.cc
M test/cctest/test-platform-win32.cc
M test/cctest/test-spaces.cc
A + test/cctest/test-virtual-memory.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
