lgtm with nits
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.cc
File src/platform/virtual-memory.cc (right):
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.cc#newcode171
src/platform/virtual-memory.cc:171: // After three attempts give up and
let the kernel find and address.
find an address
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.cc#newcode454
src/platform/virtual-memory.cc:454: bool
VirtualMemory::ProtectRegion(void* address, size_t size) {
I'd prefer a more descriptive name here. Maybe WriteProtectRegion? And
if it's called that way, could we mask out the write-bit rather than
making whatever you call this with executable?
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.h
File src/platform/virtual-memory.h (right):
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.h#newcode42
src/platform/virtual-memory.h:42: // object by assignment or
copy-contructing. This removes the reserved memory
constructing
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.h#newcode127
src/platform/virtual-memory.h:127: // to them will cause a processor
exception then.
remove "then" at the end. Reindent.
https://codereview.chromium.org/23641009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
