[v8-dev] [v8] r16624 committed - Remove V8_WARN_UNUSED_RESULT for simple getters....

Tue, 10 Sep 2013 16:19:04 -0700 

Revision: 16624
Author:   [email protected]
Date:     Tue Sep 10 15:03:17 2013 UTC
Log:      Remove V8_WARN_UNUSED_RESULT for simple getters.

[email protected]

Review URL: https://codereview.chromium.org/23629031
http://code.google.com/p/v8/source/detail?r=16624

Modified:
 /branches/bleeding_edge/src/cpu.h
 /branches/bleeding_edge/src/platform/condition-variable.h
 /branches/bleeding_edge/src/platform/elapsed-timer.h
 /branches/bleeding_edge/src/platform/mutex.h
 /branches/bleeding_edge/src/platform/semaphore.h
 /branches/bleeding_edge/src/platform/socket.h

=======================================
--- /branches/bleeding_edge/src/cpu.h   Wed Aug 28 12:32:56 2013 UTC
+++ /branches/bleeding_edge/src/cpu.h   Tue Sep 10 15:03:17 2013 UTC
@@ -100,7 +100,7 @@
   bool has_vfp3_d32() const { return has_vfp3_d32_; }

   // Returns the number of processors online.
-  static int NumberOfProcessorsOnline() V8_WARN_UNUSED_RESULT;
+  static int NumberOfProcessorsOnline();

   // Initializes the cpu architecture support. Called once at VM startup.
   static void SetUp();
=======================================
--- /branches/bleeding_edge/src/platform/condition-variable.h Tue Sep 3 07:30:01 2013 UTC +++ /branches/bleeding_edge/src/platform/condition-variable.h Tue Sep 10 15:03:17 2013 UTC 
@@ -105,10 +105,10 @@
   };
 #endif

-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }

=======================================
--- /branches/bleeding_edge/src/platform/elapsed-timer.h Mon Sep 9 05:44:54 2013 UTC +++ /branches/bleeding_edge/src/platform/elapsed-timer.h Tue Sep 10 15:03:17 2013 UTC 
@@ -87,7 +87,7 @@
// Returns the time elapsed since the previous start. This method may only 
   // be called on a previously started timer.
-  TimeDelta Elapsed() const V8_WARN_UNUSED_RESULT {
+  TimeDelta Elapsed() const {
     ASSERT(IsStarted());
     TimeDelta elapsed = Now() - start_ticks_;
     ASSERT(elapsed.InMicroseconds() >= 0);
@@ -97,13 +97,13 @@
   // Returns |true| if the specified |time_delta| has elapsed since the
   // previous start, or |false| if not. This method may only be called on
   // a previously started timer.
-  bool HasExpired(TimeDelta time_delta) const V8_WARN_UNUSED_RESULT {
+  bool HasExpired(TimeDelta time_delta) const {
     ASSERT(IsStarted());
     return Elapsed() >= time_delta;
   }

  private:
-  V8_INLINE(static TimeTicks Now()) V8_WARN_UNUSED_RESULT {
+  V8_INLINE(static TimeTicks Now()) {
     TimeTicks now = TimeTicks::HighResNow();
     ASSERT(!now.IsNull());
     return now;
=======================================
--- /branches/bleeding_edge/src/platform/mutex.h Wed Sep 4 12:55:59 2013 UTC +++ /branches/bleeding_edge/src/platform/mutex.h Tue Sep 10 15:03:17 2013 UTC 
@@ -81,10 +81,10 @@
   typedef CRITICAL_SECTION NativeHandle;
 #endif

-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }

@@ -177,10 +177,10 @@
   // The implementation-defined native handle type.
   typedef Mutex::NativeHandle NativeHandle;

-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }

=======================================
--- /branches/bleeding_edge/src/platform/semaphore.h Mon Sep 2 12:26:06 2013 UTC +++ /branches/bleeding_edge/src/platform/semaphore.h Tue Sep 10 15:03:17 2013 UTC 
@@ -80,10 +80,10 @@
   typedef HANDLE NativeHandle;
 #endif

-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }

=======================================
--- /branches/bleeding_edge/src/platform/socket.h Wed Sep 4 10:41:51 2013 UTC +++ /branches/bleeding_edge/src/platform/socket.h Tue Sep 10 15:03:17 2013 UTC 
@@ -66,11 +66,11 @@
   // Set the value of the SO_REUSEADDR socket option.
   bool SetReuseAddress(bool reuse_address);

-  V8_INLINE(bool IsValid()) const V8_WARN_UNUSED_RESULT {
+  V8_INLINE(bool IsValid()) const {
     return native_handle_ != kInvalidNativeHandle;
   }

-  static int GetLastError() V8_WARN_UNUSED_RESULT;
+  static int GetLastError();

   // The implementation-defined native handle type.
 #if V8_OS_POSIX
@@ -81,10 +81,10 @@
   static const NativeHandle kInvalidNativeHandle = INVALID_SOCKET;
 #endif

-  NativeHandle& native_handle() V8_WARN_UNUSED_RESULT {
+  NativeHandle& native_handle() {
     return native_handle_;
   }
-  const NativeHandle& native_handle() const V8_WARN_UNUSED_RESULT {
+  const NativeHandle& native_handle() const {
     return native_handle_;
   }

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to