Looking good, just one comment to address.
https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc#newcode403
src/ia32/stub-cache-ia32.cc:403:
STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == -4);
See comments in stub-cache.cc about these constants.
https://codereview.chromium.org/23620036/diff/5001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/23620036/diff/5001/src/stub-cache.cc#newcode1283
src/stub-cache.cc:1283: if (PCA::kThisIndex < PCA::kReturnValueOffset)
Instead of overlaying the indices used for the arguments object here
with PCA, we should just use a separate set of constant that describes
the layout. Decouples those two things and avoids this magic "minus 2"
computation. I would put the index constant into stub-cache.h either at
the top-level or into the StubCompiler class.
https://codereview.chromium.org/23620036/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
