On 2013/09/11 09:05:54, Toon Verwaest wrote:
lgtm with nit
https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h
File src/hydrogen-alias-analysis.h (right):
https://codereview.chromium.org/23516010/diff/4001/src/hydrogen-alias-analysis.h#newcode40
src/hydrogen-alias-analysis.h:40: };
Can we move this enum into HAliasAnalyzer?
The thinking was that this is a simple data value that doesn't necessary
"belong" to the HAliasAnalyzer; one doesn't need to have such an analyzer
to get
one of the values; I also think it looks nicer to write "HAliasing" instead
of
"HAliasAnalyzer::Aliasing".
https://codereview.chromium.org/23516010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
