lgtm with comment. Doesn't support two doubles yet, but I think it's ok to
leave
it like this until we have an actual use-case for it.
https://codereview.chromium.org/23068038/diff/8001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/23068038/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode672
src/ia32/lithium-codegen-ia32.cc:672: ASSERT(stack_depth_ <= 1);
Add comment as discussed. If ever used for other stubs than the binary
op stub, two pairs of doubles could be joined into two phis, causing a
stack-depth of 2. In that case, either the stack is in the same order in
both incoming blocks, requiring no gap; or the values on the stack need
to be swapped in one of the branches.
https://codereview.chromium.org/23068038/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
