Revision: 16651
Author: [email protected]
Date: Wed Sep 11 12:59:07 2013 UTC
Log: Improve alias analysis for HConstants (and fix small snafu in
MustAlias).
BUG=
[email protected]
Review URL: https://codereview.chromium.org/24107003
http://code.google.com/p/v8/source/detail?r=16651
Modified:
/branches/bleeding_edge/src/hydrogen-alias-analysis.h
=======================================
--- /branches/bleeding_edge/src/hydrogen-alias-analysis.h Wed Sep 11
10:53:56 2013 UTC
+++ /branches/bleeding_edge/src/hydrogen-alias-analysis.h Wed Sep 11
12:59:07 2013 UTC
@@ -65,7 +65,11 @@
if (a->IsConstant()) return kNoAlias;
}
- // TODO(titzer): return MustAlias for two equivalent constants.
+ // Constant objects can be distinguished statically.
+ if (a->IsConstant()) {
+ // TODO(titzer): DataEquals() is more efficient, but that's
protected.
+ return a->Equals(b) ? kMustAlias : kNoAlias;
+ }
return kMayAlias;
}
@@ -78,7 +82,7 @@
}
inline bool MustAlias(HValue* a, HValue* b) {
- return Query(a, b) == kMayAlias;
+ return Query(a, b) == kMustAlias;
}
inline bool NoAlias(HValue* a, HValue* b) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
