Revision: 16660
Author: [email protected]
Date: Wed Sep 11 15:44:09 2013 UTC
Log: Unify computation of load stubs in stub cache.
[email protected]
Review URL: https://codereview.chromium.org/23647011
http://code.google.com/p/v8/source/detail?r=16660
Modified:
/branches/bleeding_edge/src/ic.cc
/branches/bleeding_edge/src/stub-cache.cc
/branches/bleeding_edge/src/stub-cache.h
=======================================
--- /branches/bleeding_edge/src/ic.cc Mon Sep 9 15:03:03 2013 UTC
+++ /branches/bleeding_edge/src/ic.cc Wed Sep 11 15:44:09 2013 UTC
@@ -1318,7 +1318,7 @@
switch (lookup->type()) {
case FIELD:
return isolate()->stub_cache()->ComputeLoadField(
- name, receiver, holder,
+ name, receiver, holder, Code::LOAD_IC,
lookup->GetFieldIndex(), lookup->representation());
case CONSTANT: {
Handle<Object> constant(lookup->GetConstant(), isolate());
@@ -1326,7 +1326,7 @@
// be embedded into code.
if (constant->IsConsString()) return Handle<Code>::null();
return isolate()->stub_cache()->ComputeLoadConstant(
- name, receiver, holder, constant);
+ name, receiver, holder, Code::LOAD_IC, constant);
}
case NORMAL:
if (holder->IsGlobalObject()) {
@@ -1350,7 +1350,7 @@
if (v8::ToCData<Address>(info->getter()) == 0) break;
if (!info->IsCompatibleReceiver(*receiver)) break;
return isolate()->stub_cache()->ComputeLoadCallback(
- name, receiver, holder, info);
+ name, receiver, holder, Code::LOAD_IC, info);
} else if (callback->IsAccessorPair()) {
Handle<Object>
getter(Handle<AccessorPair>::cast(callback)->getter(),
isolate());
@@ -1363,7 +1363,7 @@
call_optimization.IsCompatibleReceiver(*receiver) &&
FLAG_js_accessor_ics) {
return isolate()->stub_cache()->ComputeLoadCallback(
- name, receiver, holder, call_optimization);
+ name, receiver, holder, Code::LOAD_IC, call_optimization);
}
return isolate()->stub_cache()->ComputeLoadViaGetter(
name, receiver, holder, function);
@@ -1372,7 +1372,8 @@
PropertyIndex lengthIndex =
PropertyIndex::NewHeaderIndex(JSArray::kLengthOffset /
kPointerSize);
return isolate()->stub_cache()->ComputeLoadField(
- name, receiver, holder, lengthIndex, Representation::Tagged());
+ name, receiver, holder, Code::LOAD_IC,
+ lengthIndex, Representation::Tagged());
}
// TODO(dcarney): Handle correctly.
if (callback->IsDeclaredAccessorInfo()) break;
@@ -1383,7 +1384,7 @@
case INTERCEPTOR:
ASSERT(HasInterceptorGetter(*holder));
return isolate()->stub_cache()->ComputeLoadInterceptor(
- name, receiver, holder);
+ name, receiver, holder, Code::LOAD_IC);
default:
break;
}
@@ -1538,16 +1539,16 @@
Handle<JSObject> holder(lookup->holder(), isolate());
switch (lookup->type()) {
case FIELD:
- return isolate()->stub_cache()->ComputeKeyedLoadField(
- name, receiver, holder,
+ return isolate()->stub_cache()->ComputeLoadField(
+ name, receiver, holder, Code::KEYED_LOAD_IC,
lookup->GetFieldIndex(), lookup->representation());
case CONSTANT: {
Handle<Object> constant(lookup->GetConstant(), isolate());
// TODO(2803): Don't compute a stub for cons strings because they
cannot
// be embedded into code.
if (constant->IsConsString()) return Handle<Code>::null();
- return isolate()->stub_cache()->ComputeKeyedLoadConstant(
- name, receiver, holder, constant);
+ return isolate()->stub_cache()->ComputeLoadConstant(
+ name, receiver, holder, Code::KEYED_LOAD_IC, constant);
}
case CALLBACKS: {
Handle<Object> callback_object(lookup->GetCallbackObject(),
isolate());
@@ -1557,8 +1558,8 @@
Handle<ExecutableAccessorInfo>::cast(callback_object);
if (v8::ToCData<Address>(callback->getter()) == 0) break;
if (!callback->IsCompatibleReceiver(*receiver)) break;
- return isolate()->stub_cache()->ComputeKeyedLoadCallback(
- name, receiver, holder, callback);
+ return isolate()->stub_cache()->ComputeLoadCallback(
+ name, receiver, holder, Code::KEYED_LOAD_IC, callback);
} else if (callback_object->IsAccessorPair()) {
Handle<Object> getter(
Handle<AccessorPair>::cast(callback_object)->getter(),
@@ -1571,16 +1572,16 @@
if (call_optimization.is_simple_api_call() &&
call_optimization.IsCompatibleReceiver(*receiver) &&
FLAG_js_accessor_ics) {
- return isolate()->stub_cache()->ComputeKeyedLoadCallback(
- name, receiver, holder, call_optimization);
+ return isolate()->stub_cache()->ComputeLoadCallback(
+ name, receiver, holder, Code::KEYED_LOAD_IC,
call_optimization);
}
}
break;
}
case INTERCEPTOR:
ASSERT(HasInterceptorGetter(lookup->holder()));
- return isolate()->stub_cache()->ComputeKeyedLoadInterceptor(
- name, receiver, holder);
+ return isolate()->stub_cache()->ComputeLoadInterceptor(
+ name, receiver, holder, Code::KEYED_LOAD_IC);
default:
// Always rewrite to the generic case so that we do not
// repeatedly try to rewrite.
=======================================
--- /branches/bleeding_edge/src/stub-cache.cc Wed Sep 11 13:42:57 2013 UTC
+++ /branches/bleeding_edge/src/stub-cache.cc Wed Sep 11 15:44:09 2013 UTC
@@ -272,21 +272,29 @@
Handle<Code> StubCache::ComputeLoadField(Handle<Name> name,
Handle<JSObject> receiver,
Handle<JSObject> holder,
+ Code::Kind kind,
PropertyIndex field,
Representation representation) {
if (receiver.is_identical_to(holder)) {
- LoadFieldStub stub(field.is_inobject(holder),
- field.translate(holder),
- representation);
- return stub.GetCode(isolate());
+ if (kind == Code::LOAD_IC) {
+ LoadFieldStub stub(field.is_inobject(holder),
+ field.translate(holder),
+ representation);
+ return stub.GetCode(isolate());
+ } else {
+ KeyedLoadFieldStub stub(field.is_inobject(holder),
+ field.translate(holder),
+ representation);
+ return stub.GetCode(isolate());
+ }
}
Handle<JSObject> stub_holder = StubHolder(receiver, holder);
Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::LOAD_IC, Code::FIELD);
+ name, receiver, stub_holder, kind, Code::FIELD);
if (!stub.is_null()) return stub;
- LoadStubCompiler compiler(isolate_);
+ BaseLoadStubCompiler compiler(isolate_, kind);
Handle<Code> handler =
compiler.CompileLoadField(receiver, holder, name, field,
representation);
JSObject::UpdateMapCodeCache(stub_holder, name, handler);
@@ -298,14 +306,15 @@
Handle<Name> name,
Handle<JSObject> receiver,
Handle<JSObject> holder,
+ Code::Kind kind,
Handle<ExecutableAccessorInfo> callback) {
ASSERT(v8::ToCData<Address>(callback->getter()) != 0);
Handle<JSObject> stub_holder = StubHolder(receiver, holder);
Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::LOAD_IC, Code::CALLBACKS);
+ name, receiver, stub_holder, kind, Code::CALLBACKS);
if (!stub.is_null()) return stub;
- LoadStubCompiler compiler(isolate_);
+ BaseLoadStubCompiler compiler(isolate_, kind);
Handle<Code> handler =
compiler.CompileLoadCallback(receiver, holder, name, callback);
JSObject::UpdateMapCodeCache(stub_holder, name, handler);
@@ -317,13 +326,14 @@
Handle<Name> name,
Handle<JSObject> receiver,
Handle<JSObject> holder,
+ Code::Kind kind,
const CallOptimization& call_optimization) {
Handle<JSObject> stub_holder = StubHolder(receiver, holder);
Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::LOAD_IC, Code::CALLBACKS);
+ name, receiver, stub_holder, kind, Code::CALLBACKS);
if (!stub.is_null()) return stub;
- LoadStubCompiler compiler(isolate_);
+ BaseLoadStubCompiler compiler(isolate_, kind);
Handle<Code> handler =
compiler.CompileLoadCallback(receiver, holder, name,
call_optimization);
JSObject::UpdateMapCodeCache(stub_holder, name, handler);
@@ -351,29 +361,30 @@
Handle<Code> StubCache::ComputeLoadConstant(Handle<Name> name,
Handle<JSObject> receiver,
Handle<JSObject> holder,
+ Code::Kind kind,
Handle<Object> value) {
Handle<JSObject> stub_holder = StubHolder(receiver, holder);
Handle<Code> handler = FindLoadHandler(
- name, receiver, stub_holder, Code::LOAD_IC, Code::CONSTANT);
+ name, receiver, stub_holder, kind, Code::CONSTANT);
if (!handler.is_null()) return handler;
- LoadStubCompiler compiler(isolate_);
+ BaseLoadStubCompiler compiler(isolate_, kind);
handler = compiler.CompileLoadConstant(receiver, holder, name, value);
JSObject::UpdateMapCodeCache(stub_holder, name, handler);
-
return handler;
}
Handle<Code> StubCache::ComputeLoadInterceptor(Handle<Name> name,
Handle<JSObject> receiver,
- Handle<JSObject> holder) {
+ Handle<JSObject> holder,
+ Code::Kind kind) {
Handle<JSObject> stub_holder = StubHolder(receiver, holder);
Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::LOAD_IC, Code::INTERCEPTOR);
+ name, receiver, stub_holder, kind, Code::INTERCEPTOR);
if (!stub.is_null()) return stub;
- LoadStubCompiler compiler(isolate_);
+ BaseLoadStubCompiler compiler(isolate_, kind);
Handle<Code> handler =
compiler.CompileLoadInterceptor(receiver, holder, name);
JSObject::UpdateMapCodeCache(stub_holder, name, handler);
@@ -402,102 +413,7 @@
JSObject::UpdateMapCodeCache(stub_holder, name, ic);
return ic;
}
-
-
-Handle<Code> StubCache::ComputeKeyedLoadField(Handle<Name> name,
- Handle<JSObject> receiver,
- Handle<JSObject> holder,
- PropertyIndex field,
- Representation
representation) {
- if (receiver.is_identical_to(holder)) {
- // TODO(titzer): this should use an HObjectAccess
- KeyedLoadFieldStub stub(field.is_inobject(holder),
- field.translate(holder),
- representation);
- return stub.GetCode(isolate());
- }
-
- Handle<JSObject> stub_holder = StubHolder(receiver, holder);
- Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::FIELD);
- if (!stub.is_null()) return stub;
-
- KeyedLoadStubCompiler compiler(isolate_);
- Handle<Code> handler =
- compiler.CompileLoadField(receiver, holder, name, field,
representation);
- JSObject::UpdateMapCodeCache(stub_holder, name, handler);
- return handler;
-}
-
-Handle<Code> StubCache::ComputeKeyedLoadConstant(Handle<Name> name,
- Handle<JSObject> receiver,
- Handle<JSObject> holder,
- Handle<Object> value) {
- Handle<JSObject> stub_holder = StubHolder(receiver, holder);
- Handle<Code> handler = FindLoadHandler(
- name, receiver, stub_holder, Code::KEYED_LOAD_IC,
- Code::CONSTANT);
- if (!handler.is_null()) return handler;
-
- KeyedLoadStubCompiler compiler(isolate_);
- handler = compiler.CompileLoadConstant(receiver, holder, name, value);
- JSObject::UpdateMapCodeCache(stub_holder, name, handler);
- return handler;
-}
-
-
-Handle<Code> StubCache::ComputeKeyedLoadInterceptor(Handle<Name> name,
- Handle<JSObject>
receiver,
- Handle<JSObject>
holder) {
- Handle<JSObject> stub_holder = StubHolder(receiver, holder);
- Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::INTERCEPTOR);
- if (!stub.is_null()) return stub;
-
- KeyedLoadStubCompiler compiler(isolate_);
- Handle<Code> handler =
- compiler.CompileLoadInterceptor(receiver, holder, name);
- JSObject::UpdateMapCodeCache(stub_holder, name, handler);
- return handler;
-}
-
-
-Handle<Code> StubCache::ComputeKeyedLoadCallback(
- Handle<Name> name,
- Handle<JSObject> receiver,
- Handle<JSObject> holder,
- Handle<ExecutableAccessorInfo> callback) {
- Handle<JSObject> stub_holder = StubHolder(receiver, holder);
- Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::CALLBACKS);
- if (!stub.is_null()) return stub;
-
- KeyedLoadStubCompiler compiler(isolate_);
- Handle<Code> handler =
- compiler.CompileLoadCallback(receiver, holder, name, callback);
- JSObject::UpdateMapCodeCache(stub_holder, name, handler);
- return handler;
-}
-
-
-Handle<Code> StubCache::ComputeKeyedLoadCallback(
- Handle<Name> name,
- Handle<JSObject> receiver,
- Handle<JSObject> holder,
- const CallOptimization& call_optimization) {
- Handle<JSObject> stub_holder = StubHolder(receiver, holder);
- Handle<Code> stub = FindLoadHandler(
- name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::CALLBACKS);
- if (!stub.is_null()) return stub;
-
- KeyedLoadStubCompiler compiler(isolate_);
- Handle<Code> handler =
- compiler.CompileLoadCallback(receiver, holder, name,
call_optimization);
- JSObject::UpdateMapCodeCache(stub_holder, name, handler);
- return handler;
-}
-
Handle<Code> StubCache::ComputeStoreField(Handle<Name> name,
Handle<JSObject> receiver,
@@ -1957,23 +1873,15 @@
}
-void LoadStubCompiler::JitEvent(Handle<Name> name, Handle<Code> code) {
- GDBJIT(AddCode(GDBJITInterface::LOAD_IC, *name, *code));
-}
-
-
-void KeyedLoadStubCompiler::JitEvent(Handle<Name> name, Handle<Code> code)
{
- GDBJIT(AddCode(GDBJITInterface::KEYED_LOAD_IC, *name, *code));
-}
-
-
-void StoreStubCompiler::JitEvent(Handle<Name> name, Handle<Code> code) {
- GDBJIT(AddCode(GDBJITInterface::STORE_IC, *name, *code));
-}
-
-
-void KeyedStoreStubCompiler::JitEvent(Handle<Name> name, Handle<Code>
code) {
- GDBJIT(AddCode(GDBJITInterface::KEYED_STORE_IC, *name, *code));
+Register* BaseLoadStoreStubCompiler::GetRegisters(Code::Kind kind) {
+ switch (kind) {
+ case Code::LOAD_IC: return LoadStubCompiler::registers();
+ case Code::STORE_IC: return StoreStubCompiler::registers();
+ case Code::KEYED_LOAD_IC: return KeyedLoadStubCompiler::registers();
+ case Code::KEYED_STORE_IC: return KeyedStoreStubCompiler::registers();
+ default: UNREACHABLE();
+ }
+ return NULL;
}
=======================================
--- /branches/bleeding_edge/src/stub-cache.h Wed Sep 11 13:34:07 2013 UTC
+++ /branches/bleeding_edge/src/stub-cache.h Wed Sep 11 15:44:09 2013 UTC
@@ -130,17 +130,20 @@
Handle<Code> ComputeLoadField(Handle<Name> name,
Handle<JSObject> object,
Handle<JSObject> holder,
+ Code::Kind kind,
PropertyIndex field_index,
Representation representation);
Handle<Code> ComputeLoadCallback(Handle<Name> name,
Handle<JSObject> object,
Handle<JSObject> holder,
+ Code::Kind kind,
Handle<ExecutableAccessorInfo>
callback);
Handle<Code> ComputeLoadCallback(Handle<Name> name,
Handle<JSObject> object,
Handle<JSObject> holder,
+ Code::Kind kind,
const CallOptimization&
call_optimization);
Handle<Code> ComputeLoadViaGetter(Handle<Name> name,
@@ -151,11 +154,13 @@
Handle<Code> ComputeLoadConstant(Handle<Name> name,
Handle<JSObject> object,
Handle<JSObject> holder,
+ Code::Kind kind,
Handle<Object> value);
Handle<Code> ComputeLoadInterceptor(Handle<Name> name,
Handle<JSObject> object,
- Handle<JSObject> holder);
+ Handle<JSObject> holder,
+ Code::Kind kind);
Handle<Code> ComputeLoadNormal(Handle<Name> name,
Handle<JSObject> object);
@@ -166,35 +171,6 @@
Handle<PropertyCell> cell,
bool is_dont_delete);
- // ---
-
- Handle<Code> ComputeKeyedLoadField(Handle<Name> name,
- Handle<JSObject> object,
- Handle<JSObject> holder,
- PropertyIndex field_index,
- Representation representation);
-
- Handle<Code> ComputeKeyedLoadCallback(
- Handle<Name> name,
- Handle<JSObject> object,
- Handle<JSObject> holder,
- Handle<ExecutableAccessorInfo> callback);
-
- Handle<Code> ComputeKeyedLoadCallback(
- Handle<Name> name,
- Handle<JSObject> object,
- Handle<JSObject> holder,
- const CallOptimization& call_optimization);
-
- Handle<Code> ComputeKeyedLoadConstant(Handle<Name> name,
- Handle<JSObject> object,
- Handle<JSObject> holder,
- Handle<Object> value);
-
- Handle<Code> ComputeKeyedLoadInterceptor(Handle<Name> name,
- Handle<JSObject> object,
- Handle<JSObject> holder);
-
// ---
Handle<Code> ComputeStoreField(Handle<Name> name,
@@ -642,8 +618,10 @@
class BaseLoadStoreStubCompiler: public StubCompiler {
public:
- BaseLoadStoreStubCompiler(Isolate* isolate, Register* registers)
- : StubCompiler(isolate), registers_(registers) { }
+ BaseLoadStoreStubCompiler(Isolate* isolate,
+ Code::Kind kind,
+ Register* registers)
+ : StubCompiler(isolate), kind_(kind), registers_(registers) { }
virtual ~BaseLoadStoreStubCompiler() { }
Handle<Code> CompileMonomorphicIC(Handle<Map> receiver_map,
@@ -670,6 +648,17 @@
}
return Builtins::kLoadIC_Miss;
}
+
+ static GDBJITInterface::CodeTag GetGDBJITCodeTag(Code::Kind kind) {
+ switch (kind) {
+ case Code::LOAD_IC: return GDBJITInterface::LOAD_IC;
+ case Code::STORE_IC: return GDBJITInterface::STORE_IC;
+ case Code::KEYED_LOAD_IC: return GDBJITInterface::KEYED_LOAD_IC;
+ case Code::KEYED_STORE_IC: return GDBJITInterface::KEYED_STORE_IC;
+ default: UNREACHABLE();
+ }
+ return static_cast<GDBJITInterface::CodeTag>(0);
+ }
protected:
virtual Register HandlerFrontendHeader(Handle<JSObject> object,
@@ -693,24 +682,48 @@
Handle<Name> name,
InlineCacheState state = MONOMORPHIC);
+ virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) {
+ if (!code->is_inline_cache_stub()) return Logger::STUB_TAG;
+ switch (kind()) {
+ case Code::LOAD_IC: return code->ic_state() == MONOMORPHIC
+ ? Logger::LOAD_IC_TAG : Logger::LOAD_POLYMORPHIC_IC_TAG;
+ case Code::STORE_IC: return code->ic_state() == MONOMORPHIC
+ ? Logger::STORE_IC_TAG : Logger::STORE_POLYMORPHIC_IC_TAG;
+ case Code::KEYED_LOAD_IC: return code->ic_state() == MONOMORPHIC
+ ? Logger::KEYED_LOAD_IC_TAG :
Logger::KEYED_LOAD_POLYMORPHIC_IC_TAG;
+ case Code::KEYED_STORE_IC: return code->ic_state() == MONOMORPHIC
+ ? Logger::KEYED_STORE_IC_TAG :
Logger::KEYED_STORE_POLYMORPHIC_IC_TAG;
+ default: UNREACHABLE();
+ }
+ return static_cast<Logger::LogEventsAndTags>(0);
+ }
+
+ void JitEvent(Handle<Name> name, Handle<Code> code) {
+ GDBJIT(AddCode(GetGDBJITCodeTag(kind()), *name, *code));
+ }
+
+ Code::Kind kind() const { return kind_; }
+
virtual Code::ExtraICState extra_state() { return Code::kNoExtraICState;
}
- virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) = 0;
- virtual void JitEvent(Handle<Name> name, Handle<Code> code) = 0;
- virtual Code::Kind kind() = 0;
virtual Register receiver() = 0;
virtual Register name() = 0;
virtual Register scratch1() = 0;
virtual Register scratch2() = 0;
virtual Register scratch3() = 0;
+ static Register* GetRegisters(Code::Kind kind);
+
+ Code::Kind kind_;
Register* registers_;
};
class BaseLoadStubCompiler: public BaseLoadStoreStubCompiler {
public:
- BaseLoadStubCompiler(Isolate* isolate, Register* registers)
- : BaseLoadStoreStubCompiler(isolate, registers) { }
+ BaseLoadStubCompiler(Isolate* isolate, Code::Kind kind)
+ : BaseLoadStoreStubCompiler(isolate, kind, GetRegisters(kind)) { }
+ BaseLoadStubCompiler(Isolate* isolate, Code::Kind kind, Register*
registers)
+ : BaseLoadStoreStubCompiler(isolate, kind, registers) { }
virtual ~BaseLoadStubCompiler() { }
Handle<Code> CompileLoadField(Handle<JSObject> object,
@@ -795,7 +808,7 @@
class LoadStubCompiler: public BaseLoadStubCompiler {
public:
explicit LoadStubCompiler(Isolate* isolate)
- : BaseLoadStubCompiler(isolate, registers()) { }
+ : BaseLoadStubCompiler(isolate, Code::LOAD_IC, registers()) { }
Handle<Code> CompileLoadNonexistent(Handle<JSObject> object,
Handle<JSObject> last,
@@ -816,22 +829,14 @@
Handle<Name> name,
bool is_dont_delete);
- private:
static Register* registers();
- virtual Code::Kind kind() { return Code::LOAD_IC; }
- virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) {
- if (!code->is_inline_cache_stub()) return Logger::STUB_TAG;
- return code->ic_state() == MONOMORPHIC
- ? Logger::LOAD_IC_TAG : Logger::LOAD_POLYMORPHIC_IC_TAG;
- }
- virtual void JitEvent(Handle<Name> name, Handle<Code> code);
};
class KeyedLoadStubCompiler: public BaseLoadStubCompiler {
public:
explicit KeyedLoadStubCompiler(Isolate* isolate)
- : BaseLoadStubCompiler(isolate, registers()) { }
+ : BaseLoadStubCompiler(isolate, Code::KEYED_LOAD_IC, registers()) { }
Handle<Code> CompileLoadElement(Handle<Map> receiver_map);
@@ -840,15 +845,9 @@
static void GenerateLoadDictionaryElement(MacroAssembler* masm);
- private:
static Register* registers();
- virtual Code::Kind kind() { return Code::KEYED_LOAD_IC; }
- virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) {
- if (!code->is_inline_cache_stub()) return Logger::STUB_TAG;
- return code->ic_state() == MONOMORPHIC
- ? Logger::KEYED_LOAD_IC_TAG :
Logger::KEYED_LOAD_POLYMORPHIC_IC_TAG;
- }
- virtual void JitEvent(Handle<Name> name, Handle<Code> code);
+
+ private:
virtual void GenerateNameCheck(Handle<Name> name,
Register name_reg,
Label* miss);
@@ -858,9 +857,9 @@
class BaseStoreStubCompiler: public BaseLoadStoreStubCompiler {
public:
BaseStoreStubCompiler(Isolate* isolate,
- StrictModeFlag strict_mode,
- Register* registers)
- : BaseLoadStoreStubCompiler(isolate, registers),
+ Code::Kind kind,
+ StrictModeFlag strict_mode)
+ : BaseLoadStoreStubCompiler(isolate, kind, GetRegisters(kind)),
strict_mode_(strict_mode) { }
virtual ~BaseStoreStubCompiler() { }
@@ -958,7 +957,7 @@
class StoreStubCompiler: public BaseStoreStubCompiler {
public:
StoreStubCompiler(Isolate* isolate, StrictModeFlag strict_mode)
- : BaseStoreStubCompiler(isolate, strict_mode, registers()) { }
+ : BaseStoreStubCompiler(isolate, Code::STORE_IC, strict_mode) { }
Handle<Code> CompileStoreCallback(Handle<JSObject> object,
@@ -982,15 +981,7 @@
Handle<Code> CompileStoreInterceptor(Handle<JSObject> object,
Handle<Name> name);
- private:
static Register* registers();
- virtual Code::Kind kind() { return Code::STORE_IC; }
- virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) {
- if (!code->is_inline_cache_stub()) return Logger::STUB_TAG;
- return code->ic_state() == MONOMORPHIC
- ? Logger::STORE_IC_TAG : Logger::STORE_POLYMORPHIC_IC_TAG;
- }
- virtual void JitEvent(Handle<Name> name, Handle<Code> code);
};
@@ -999,7 +990,7 @@
KeyedStoreStubCompiler(Isolate* isolate,
StrictModeFlag strict_mode,
KeyedAccessStoreMode store_mode)
- : BaseStoreStubCompiler(isolate, strict_mode, registers()),
+ : BaseStoreStubCompiler(isolate, Code::KEYED_STORE_IC, strict_mode),
store_mode_(store_mode) { }
Handle<Code> CompileStoreElement(Handle<Map> receiver_map);
@@ -1012,6 +1003,8 @@
static void GenerateStoreDictionaryElement(MacroAssembler* masm);
+ static Register* registers();
+
protected:
virtual Code::ExtraICState extra_state() {
return Code::ComputeExtraICState(store_mode_, strict_mode());
@@ -1022,14 +1015,6 @@
return registers()[3];
}
- static Register* registers();
- virtual Code::Kind kind() { return Code::KEYED_STORE_IC; }
- virtual Logger::LogEventsAndTags log_kind(Handle<Code> code) {
- if (!code->is_inline_cache_stub()) return Logger::STUB_TAG;
- return code->ic_state() == MONOMORPHIC
- ? Logger::KEYED_STORE_IC_TAG :
Logger::KEYED_STORE_POLYMORPHIC_IC_TAG;
- }
- virtual void JitEvent(Handle<Name> name, Handle<Code> code);
virtual void GenerateNameCheck(Handle<Name> name,
Register name_reg,
Label* miss);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
