Reviewers: Benedikt Meurer,
Message:
On 2013/09/12 07:06:10, Benedikt Meurer wrote:
Your CL upload is broken.
It's OK now.
Description:
Save one branch for normal heap number un-tagging.
BUG=NONE
TEST=NONE
Please review this at https://codereview.chromium.org/23496041/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -1 lines):
M src/arm/lithium-codegen-arm.cc
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index
cf76a086720a7282487f2d59ddd09f6938c79759..e264cc7c4df768fe192beafe55f5882120d9eebf
100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -4886,7 +4886,13 @@ void LCodeGen::EmitNumberUntagD(Register input_reg,
DeoptimizeIf(ne, env);
} else {
Label heap_number, convert;
+ if (!deoptimize_on_minus_zero) {
+ __ vldr(result_reg, input_reg,
+ HeapNumber::kValueOffset - kHeapObjectTag, eq);
+ __ b(eq, &done);
+ } else {
__ b(eq, &heap_number);
+ }
// Convert undefined (and hole) to NaN.
__ LoadRoot(ip, Heap::kUndefinedValueRootIndex);
@@ -4900,8 +4906,11 @@ void LCodeGen::EmitNumberUntagD(Register input_reg,
__ bind(&heap_number);
}
+
// Heap number to double register conversion.
- __ vldr(result_reg, input_reg, HeapNumber::kValueOffset -
kHeapObjectTag);
+ if (!can_convert_undefined_to_nan || deoptimize_on_minus_zero) {
+ __ vldr(result_reg, input_reg, HeapNumber::kValueOffset -
kHeapObjectTag);
+ }
if (deoptimize_on_minus_zero) {
__ VmovLow(scratch, result_reg);
__ cmp(scratch, Operand::Zero());
@@ -4925,6 +4934,7 @@ void LCodeGen::EmitNumberUntagD(Register input_reg,
}
+
void LCodeGen::DoDeferredTaggedToI(LTaggedToI* instr) {
Register input_reg = ToRegister(instr->value());
Register scratch1 = scratch0();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
