Revision: 16669
Author: [email protected]
Date: Thu Sep 12 08:57:10 2013 UTC
Log: Reland "Deuglify V8_INLINE and V8_NOINLINE."
[email protected]
Review URL: https://codereview.chromium.org/23604054
http://code.google.com/p/v8/source/detail?r=16669
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/include/v8config.h
/branches/bleeding_edge/src/cpu.cc
/branches/bleeding_edge/src/globals.h
/branches/bleeding_edge/src/platform/elapsed-timer.h
/branches/bleeding_edge/src/platform/mutex.cc
/branches/bleeding_edge/src/platform/mutex.h
/branches/bleeding_edge/src/platform/socket.h
/branches/bleeding_edge/src/spaces.h
/branches/bleeding_edge/src/utils/random-number-generator.h
/branches/bleeding_edge/test/cctest/test-api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Wed Sep 11 18:30:01 2013 UTC
+++ /branches/bleeding_edge/include/v8.h Thu Sep 12 08:57:10 2013 UTC
@@ -211,7 +211,7 @@
/**
* Creates an empty handle.
*/
- V8_INLINE(Handle()) : val_(0) {}
+ V8_INLINE Handle() : val_(0) {}
/**
* Creates a handle for the contents of the specified handle. This
@@ -223,7 +223,7 @@
* Handle<String> to a variable declared as Handle<Value>, is legal
* because String is a subclass of Value.
*/
- template <class S> V8_INLINE(Handle(Handle<S> that))
+ template <class S> V8_INLINE Handle(Handle<S> that)
: val_(reinterpret_cast<T*>(*that)) {
/**
* This check fails when trying to convert between incompatible
@@ -236,16 +236,16 @@
/**
* Returns true if the handle is empty.
*/
- V8_INLINE(bool IsEmpty() const) { return val_ == 0; }
+ V8_INLINE bool IsEmpty() const { return val_ == 0; }
/**
* Sets the handle to be empty. IsEmpty() will then return true.
*/
- V8_INLINE(void Clear()) { val_ = 0; }
+ V8_INLINE void Clear() { val_ = 0; }
- V8_INLINE(T* operator->() const) { return val_; }
+ V8_INLINE T* operator->() const { return val_; }
- V8_INLINE(T* operator*() const) { return val_; }
+ V8_INLINE T* operator*() const { return val_; }
/**
* Checks whether two handles are the same.
@@ -253,7 +253,7 @@
* to which they refer are identical.
* The handles' references are not checked.
*/
- template <class S> V8_INLINE(bool operator==(const Handle<S>& that)
const) {
+ template <class S> V8_INLINE bool operator==(const Handle<S>& that)
const {
internal::Object** a = reinterpret_cast<internal::Object**>(**this);
internal::Object** b = reinterpret_cast<internal::Object**>(*that);
if (a == 0) return b == 0;
@@ -261,8 +261,8 @@
return *a == *b;
}
- template <class S> V8_INLINE(
- bool operator==(const Persistent<S>& that) const) {
+ template <class S> V8_INLINE bool operator==(
+ const Persistent<S>& that) const {
internal::Object** a = reinterpret_cast<internal::Object**>(**this);
internal::Object** b = reinterpret_cast<internal::Object**>(*that);
if (a == 0) return b == 0;
@@ -276,16 +276,16 @@
* the objects to which they refer are different.
* The handles' references are not checked.
*/
- template <class S> V8_INLINE(bool operator!=(const Handle<S>& that)
const) {
+ template <class S> V8_INLINE bool operator!=(const Handle<S>& that)
const {
return !operator==(that);
}
- template <class S> V8_INLINE(
- bool operator!=(const Persistent<S>& that) const) {
+ template <class S> V8_INLINE bool operator!=(
+ const Persistent<S>& that) const {
return !operator==(that);
}
- template <class S> V8_INLINE(static Handle<T> Cast(Handle<S> that)) {
+ template <class S> V8_INLINE static Handle<T> Cast(Handle<S> that) {
#ifdef V8_ENABLE_CHECKS
// If we're going to perform the type check then we have to check
// that the handle isn't empty before doing the checked cast.
@@ -294,14 +294,14 @@
return Handle<T>(T::Cast(*that));
}
- template <class S> V8_INLINE(Handle<S> As()) {
+ template <class S> V8_INLINE Handle<S> As() {
return Handle<S>::Cast(*this);
}
- V8_INLINE(static Handle<T> New(Isolate* isolate, Handle<T> that)) {
+ V8_INLINE static Handle<T> New(Isolate* isolate, Handle<T> that) {
return New(isolate, that.val_);
}
- V8_INLINE(static Handle<T> New(Isolate* isolate, const Persistent<T>&
that)) {
+ V8_INLINE static Handle<T> New(Isolate* isolate, const Persistent<T>&
that) {
return New(isolate, that.val_);
}
@@ -312,7 +312,7 @@
/**
* Creates a new handle for the specified value.
*/
- V8_INLINE(explicit Handle(T* val)) : val_(val) {}
+ V8_INLINE explicit Handle(T* val) : val_(val) {}
private:
friend class Utils;
@@ -328,7 +328,7 @@
friend class Context;
friend class HandleScope;
- V8_INLINE(static Handle<T> New(Isolate* isolate, T* that));
+ V8_INLINE static Handle<T> New(Isolate* isolate, T* that);
T* val_;
};
@@ -343,8 +343,8 @@
*/
template <class T> class Local : public Handle<T> {
public:
- V8_INLINE(Local());
- template <class S> V8_INLINE(Local(Local<S> that))
+ V8_INLINE Local();
+ template <class S> V8_INLINE Local(Local<S> that)
: Handle<T>(reinterpret_cast<T*>(*that)) {
/**
* This check fails when trying to convert between incompatible
@@ -355,7 +355,7 @@
}
- template <class S> V8_INLINE(static Local<T> Cast(Local<S> that)) {
+ template <class S> V8_INLINE static Local<T> Cast(Local<S> that) {
#ifdef V8_ENABLE_CHECKS
// If we're going to perform the type check then we have to check
// that the handle isn't empty before doing the checked cast.
@@ -363,12 +363,12 @@
#endif
return Local<T>(T::Cast(*that));
}
- template <class S> V8_INLINE(Local(Handle<S> that))
+ template <class S> V8_INLINE Local(Handle<S> that)
: Handle<T>(reinterpret_cast<T*>(*that)) {
TYPE_CHECK(T, S);
}
- template <class S> V8_INLINE(Local<S> As()) {
+ template <class S> V8_INLINE Local<S> As() {
return Local<S>::Cast(*this);
}
@@ -377,17 +377,17 @@
* The referee is kept alive by the local handle even when
* the original handle is destroyed/disposed.
*/
- V8_INLINE(static Local<T> New(Handle<T> that));
- V8_INLINE(static Local<T> New(Isolate* isolate, Handle<T> that));
+ V8_INLINE static Local<T> New(Handle<T> that);
+ V8_INLINE static Local<T> New(Isolate* isolate, Handle<T> that);
template<class M>
- V8_INLINE(static Local<T> New(Isolate* isolate,
- const Persistent<T, M>& that));
+ V8_INLINE static Local<T> New(Isolate* isolate,
+ const Persistent<T, M>& that);
#ifndef V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR
private:
#endif
- template <class S> V8_INLINE(Local(S* that) : Handle<T>(that)) { }
+ template <class S> V8_INLINE Local(S* that) : Handle<T>(that) { }
private:
friend class Utils;
@@ -402,24 +402,22 @@
template<class F> friend class internal::CustomArguments;
friend class HandleScope;
- V8_INLINE(static Local<T> New(Isolate* isolate, T* that));
+ V8_INLINE static Local<T> New(Isolate* isolate, T* that);
};
// Eternal handles are set-once handles that live for the life of the
isolate.
template <class T> class Eternal {
public:
- V8_INLINE(Eternal()) : index_(kInitialValue) { }
+ V8_INLINE Eternal() : index_(kInitialValue) { }
template<class S>
- V8_INLINE(Eternal(Isolate* isolate, Local<S> handle))
- : index_(kInitialValue) {
+ V8_INLINE Eternal(Isolate* isolate, Local<S> handle) :
index_(kInitialValue) {
Set(isolate, handle);
}
// Can only be safely called if already set.
- V8_INLINE(Local<T> Get(Isolate* isolate));
- V8_INLINE(bool IsEmpty()) { return index_ == kInitialValue; }
- template<class S>
- V8_INLINE(void Set(Isolate* isolate, Local<S> handle));
+ V8_INLINE Local<T> Get(Isolate* isolate);
+ V8_INLINE bool IsEmpty() { return index_ == kInitialValue; }
+ template<class S> V8_INLINE void Set(Isolate* isolate, Local<S> handle);
private:
static const int kInitialValue = -1;
@@ -432,9 +430,9 @@
public:
typedef void (*Callback)(const WeakCallbackData<T, P>& data);
- V8_INLINE(Isolate* GetIsolate()) const { return isolate_; }
- V8_INLINE(Local<T> GetValue()) const { return handle_; }
- V8_INLINE(P* GetParameter()) const { return parameter_; }
+ V8_INLINE Isolate* GetIsolate() const { return isolate_; }
+ V8_INLINE Local<T> GetValue() const { return handle_; }
+ V8_INLINE P* GetParameter() const { return parameter_; }
private:
friend class internal::GlobalHandles;
@@ -470,13 +468,12 @@
typedef Persistent<T, NonCopyablePersistentTraits<T> >
NonCopyablePersistent;
static const bool kResetInDestructor = false;
template<class S, class M>
- V8_INLINE(static void Copy(const Persistent<S, M>& source,
- NonCopyablePersistent* dest)) {
+ V8_INLINE static void Copy(const Persistent<S, M>& source,
+ NonCopyablePersistent* dest) {
Uncompilable<Object>();
}
// TODO(dcarney): come up with a good compile error here.
- template<class O>
- V8_INLINE(static void Uncompilable()) {
+ template<class O> V8_INLINE static void Uncompilable() {
TYPE_CHECK(O, Primitive);
}
};
@@ -502,13 +499,13 @@
/**
* A Persistent with no storage cell.
*/
- V8_INLINE(Persistent()) : val_(0) { }
+ V8_INLINE Persistent() : val_(0) { }
/**
* Construct a Persistent from a Handle.
* When the Handle is non-empty, a new storage cell is created
* pointing to the same object, and no flags are set.
*/
- template <class S> V8_INLINE(Persistent(Isolate* isolate, Handle<S>
that))
+ template <class S> V8_INLINE Persistent(Isolate* isolate, Handle<S> that)
: val_(New(isolate, *that)) {
TYPE_CHECK(T, S);
}
@@ -518,7 +515,7 @@
* pointing to the same object, and no flags are set.
*/
template <class S, class M2>
- V8_INLINE(Persistent(Isolate* isolate, const Persistent<S, M2>& that))
+ V8_INLINE Persistent(Isolate* isolate, const Persistent<S, M2>& that)
: val_(New(isolate, *that)) {
TYPE_CHECK(T, S);
}
@@ -528,19 +525,19 @@
* traits class is called, allowing the setting of flags based on the
* copied Persistent.
*/
- V8_INLINE(Persistent(const Persistent& that)) : val_(0) {
+ V8_INLINE Persistent(const Persistent& that) : val_(0) {
Copy(that);
}
template <class S, class M2>
- V8_INLINE(Persistent(const Persistent<S, M2>& that)) : val_(0) {
+ V8_INLINE Persistent(const Persistent<S, M2>& that) : val_(0) {
Copy(that);
}
- V8_INLINE(Persistent& operator=(const Persistent& that)) { // NOLINT
+ V8_INLINE Persistent& operator=(const Persistent& that) { // NOLINT
Copy(that);
return *this;
}
template <class S, class M2>
- V8_INLINE(Persistent& operator=(const Persistent<S, M2>& that)) { //
NOLINT
+ V8_INLINE Persistent& operator=(const Persistent<S, M2>& that) { //
NOLINT
Copy(that);
return *this;
}
@@ -549,7 +546,7 @@
* kResetInDestructor flags in the traits class. Since not calling
dispose
* can result in a memory leak, it is recommended to always set this
flag.
*/
- V8_INLINE(~Persistent()) {
+ V8_INLINE ~Persistent() {
if (M::kResetInDestructor) Reset();
}
@@ -557,28 +554,28 @@
* If non-empty, destroy the underlying storage cell
* IsEmpty() will return true after this call.
*/
- V8_INLINE(void Reset());
- template <class S>
+ V8_INLINE void Reset();
/**
* If non-empty, destroy the underlying storage cell
* and create a new one with the contents of other if other is non empty
*/
- V8_INLINE(void Reset(Isolate* isolate, const Handle<S>& other));
+ template <class S>
+ V8_INLINE void Reset(Isolate* isolate, const Handle<S>& other);
/**
* If non-empty, destroy the underlying storage cell
* and create a new one with the contents of other if other is non empty
*/
template <class S, class M2>
- V8_INLINE(void Reset(Isolate* isolate, const Persistent<S, M2>& other));
+ V8_INLINE void Reset(Isolate* isolate, const Persistent<S, M2>& other);
// TODO(dcarney): deprecate
- V8_INLINE(void Dispose()) { Reset(); }
- V8_DEPRECATED(V8_INLINE(void Dispose(Isolate* isolate))) { Reset(); }
+ V8_INLINE void Dispose() { Reset(); }
+ V8_DEPRECATED(V8_INLINE void Dispose(Isolate* isolate)) { Reset(); }
- V8_INLINE(bool IsEmpty() const) { return val_ == 0; }
+ V8_INLINE bool IsEmpty() const { return val_ == 0; }
// TODO(dcarney): this is pretty useless, fix or remove
template <class S>
- V8_INLINE(static Persistent<T>& Cast(Persistent<S>& that)) { // NOLINT
+ V8_INLINE static Persistent<T>& Cast(Persistent<S>& that) { // NOLINT
#ifdef V8_ENABLE_CHECKS
// If we're going to perform the type check then we have to check
// that the handle isn't empty before doing the checked cast.
@@ -588,12 +585,12 @@
}
// TODO(dcarney): this is pretty useless, fix or remove
- template <class S> V8_INLINE(Persistent<S>& As()) { // NOLINT
+ template <class S> V8_INLINE Persistent<S>& As() { // NOLINT
return Persistent<S>::Cast(*this);
}
- template <class S, class M2> V8_INLINE(
- bool operator==(const Persistent<S, M2>& that) const) {
+ template <class S, class M2>
+ V8_INLINE bool operator==(const Persistent<S, M2>& that) const {
internal::Object** a = reinterpret_cast<internal::Object**>(**this);
internal::Object** b = reinterpret_cast<internal::Object**>(*that);
if (a == 0) return b == 0;
@@ -601,7 +598,7 @@
return *a == *b;
}
- template <class S> V8_INLINE(bool operator==(const Handle<S>& that)
const) {
+ template <class S> V8_INLINE bool operator==(const Handle<S>& that)
const {
internal::Object** a = reinterpret_cast<internal::Object**>(**this);
internal::Object** b = reinterpret_cast<internal::Object**>(*that);
if (a == 0) return b == 0;
@@ -609,40 +606,40 @@
return *a == *b;
}
- template <class S, class M2> V8_INLINE(
- bool operator!=(const Persistent<S, M2>& that) const) {
+ template <class S, class M2>
+ V8_INLINE bool operator!=(const Persistent<S, M2>& that) const {
return !operator==(that);
}
- template <class S> V8_INLINE(bool operator!=(const Handle<S>& that)
const) {
+ template <class S> V8_INLINE bool operator!=(const Handle<S>& that)
const {
return !operator==(that);
}
template<typename P>
- V8_INLINE(void SetWeak(
+ V8_INLINE void SetWeak(
P* parameter,
- typename WeakCallbackData<T, P>::Callback callback));
+ typename WeakCallbackData<T, P>::Callback callback);
template<typename S, typename P>
- V8_INLINE(void SetWeak(
+ V8_INLINE void SetWeak(
P* parameter,
- typename WeakCallbackData<S, P>::Callback callback));
+ typename WeakCallbackData<S, P>::Callback callback);
// TODO(dcarney): deprecate
template<typename S, typename P>
- V8_INLINE(void MakeWeak(
+ V8_INLINE void MakeWeak(
P* parameter,
- typename WeakReferenceCallbacks<S, P>::Revivable callback));
+ typename WeakReferenceCallbacks<S, P>::Revivable callback);
// TODO(dcarney): deprecate
template<typename P>
- V8_INLINE(void MakeWeak(
+ V8_INLINE void MakeWeak(
P* parameter,
- typename WeakReferenceCallbacks<T, P>::Revivable callback));
+ typename WeakReferenceCallbacks<T, P>::Revivable callback);
- V8_INLINE(void ClearWeak());
+ V8_INLINE void ClearWeak();
- V8_DEPRECATED(V8_INLINE(void ClearWeak(Isolate* isolate))) {
ClearWeak(); }
+ V8_DEPRECATED(V8_INLINE void ClearWeak(Isolate* isolate)) { ClearWeak();
}
/**
* Marks the reference to this object independent. Garbage collector is
free
@@ -650,9 +647,9 @@
* independent handle should not assume that it will be preceded by a
global
* GC prologue callback or followed by a global GC epilogue callback.
*/
- V8_INLINE(void MarkIndependent());
+ V8_INLINE void MarkIndependent();
- V8_DEPRECATED(V8_INLINE(void MarkIndependent(Isolate* isolate))) {
+ V8_DEPRECATED(V8_INLINE void MarkIndependent(Isolate* isolate)) {
MarkIndependent();
}
@@ -664,29 +661,29 @@
* external dependencies. This mark is automatically cleared after each
* garbage collection.
*/
- V8_INLINE(void MarkPartiallyDependent());
+ V8_INLINE void MarkPartiallyDependent();
- V8_DEPRECATED(V8_INLINE(void MarkPartiallyDependent(Isolate* isolate))) {
+ V8_DEPRECATED(V8_INLINE void MarkPartiallyDependent(Isolate* isolate)) {
MarkPartiallyDependent();
}
- V8_INLINE(bool IsIndependent() const);
+ V8_INLINE bool IsIndependent() const;
- V8_DEPRECATED(V8_INLINE(bool IsIndependent(Isolate* isolate)) const) {
+ V8_DEPRECATED(V8_INLINE bool IsIndependent(Isolate* isolate) const) {
return IsIndependent();
}
/** Checks if the handle holds the only reference to an object. */
- V8_INLINE(bool IsNearDeath() const);
+ V8_INLINE bool IsNearDeath() const;
- V8_DEPRECATED(V8_INLINE(bool IsNearDeath(Isolate* isolate)) const) {
+ V8_DEPRECATED(V8_INLINE bool IsNearDeath(Isolate* isolate) const) {
return IsNearDeath();
}
/** Returns true if the handle's reference is weak. */
- V8_INLINE(bool IsWeak() const);
+ V8_INLINE bool IsWeak() const;
- V8_DEPRECATED(V8_INLINE(bool IsWeak(Isolate* isolate)) const) {
+ V8_DEPRECATED(V8_INLINE bool IsWeak(Isolate* isolate) const) {
return IsWeak();
}
@@ -694,10 +691,10 @@
* Assigns a wrapper class ID to the handle. See RetainedObjectInfo
interface
* description in v8-profiler.h for details.
*/
- V8_INLINE(void SetWrapperClassId(uint16_t class_id));
+ V8_INLINE void SetWrapperClassId(uint16_t class_id);
V8_DEPRECATED(
- V8_INLINE(void SetWrapperClassId(Isolate * isolate, uint16_t
class_id))) {
+ V8_INLINE void SetWrapperClassId(Isolate * isolate, uint16_t
class_id)) {
SetWrapperClassId(class_id);
}
@@ -705,26 +702,26 @@
* Returns the class ID previously assigned to this handle or 0 if no
class ID
* was previously assigned.
*/
- V8_INLINE(uint16_t WrapperClassId() const);
+ V8_INLINE uint16_t WrapperClassId() const;
- V8_DEPRECATED(V8_INLINE(uint16_t WrapperClassId(Isolate* isolate))
const) {
+ V8_DEPRECATED(V8_INLINE uint16_t WrapperClassId(Isolate* isolate) const)
{
return WrapperClassId();
}
// TODO(dcarney): remove
- V8_INLINE(T* ClearAndLeak());
+ V8_INLINE T* ClearAndLeak();
// TODO(dcarney): remove
- V8_INLINE(void Clear()) { val_ = 0; }
+ V8_INLINE void Clear() { val_ = 0; }
// TODO(dcarney): remove
#ifndef V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR
private:
#endif
- template <class S> V8_INLINE(Persistent(S* that)) : val_(that) { }
+ template <class S> V8_INLINE Persistent(S* that) : val_(that) { }
- V8_INLINE(T* operator*() const) { return val_; }
+ V8_INLINE T* operator*() const { return val_; }
private:
friend class Utils;
@@ -733,9 +730,9 @@
template<class F1, class F2> friend class Persistent;
template<class F> friend class ReturnValue;
- V8_INLINE(static T* New(Isolate* isolate, T* that));
+ V8_INLINE static T* New(Isolate* isolate, T* that);
template<class S, class M2>
- V8_INLINE(void Copy(const Persistent<S, M2>& that));
+ V8_INLINE void Copy(const Persistent<S, M2>& that);
T* val_;
};
@@ -795,7 +792,7 @@
internal::Object** next;
internal::Object** limit;
int level;
- V8_INLINE(void Initialize()) {
+ V8_INLINE void Initialize() {
next = limit = NULL;
level = 0;
}
@@ -904,19 +901,19 @@
*/
class ScriptOrigin {
public:
- V8_INLINE(ScriptOrigin(
+ V8_INLINE ScriptOrigin(
Handle<Value> resource_name,
Handle<Integer> resource_line_offset = Handle<Integer>(),
Handle<Integer> resource_column_offset = Handle<Integer>(),
- Handle<Boolean> resource_is_shared_cross_origin = Handle<Boolean>()))
+ Handle<Boolean> resource_is_shared_cross_origin = Handle<Boolean>())
: resource_name_(resource_name),
resource_line_offset_(resource_line_offset),
resource_column_offset_(resource_column_offset),
resource_is_shared_cross_origin_(resource_is_shared_cross_origin)
{ }
- V8_INLINE(Handle<Value> ResourceName() const);
- V8_INLINE(Handle<Integer> ResourceLineOffset() const);
- V8_INLINE(Handle<Integer> ResourceColumnOffset() const);
- V8_INLINE(Handle<Boolean> ResourceIsSharedCrossOrigin() const);
+ V8_INLINE Handle<Value> ResourceName() const;
+ V8_INLINE Handle<Integer> ResourceLineOffset() const;
+ V8_INLINE Handle<Integer> ResourceColumnOffset() const;
+ V8_INLINE Handle<Boolean> ResourceIsSharedCrossOrigin() const;
private:
Handle<Value> resource_name_;
Handle<Integer> resource_line_offset_;
@@ -1257,13 +1254,13 @@
* Returns true if this value is the undefined value. See ECMA-262
* 4.3.10.
*/
- V8_INLINE(bool IsUndefined() const);
+ V8_INLINE bool IsUndefined() const;
/**
* Returns true if this value is the null value. See ECMA-262
* 4.3.11.
*/
- V8_INLINE(bool IsNull() const);
+ V8_INLINE bool IsNull() const;
/**
* Returns true if this value is true.
@@ -1279,7 +1276,7 @@
* Returns true if this value is an instance of the String type.
* See ECMA-262 8.4.
*/
- V8_INLINE(bool IsString() const);
+ V8_INLINE bool IsString() const;
/**
* Returns true if this value is a symbol.
@@ -1467,12 +1464,12 @@
bool Equals(Handle<Value> that) const;
bool StrictEquals(Handle<Value> that) const;
- template <class T> V8_INLINE(static Value* Cast(T* value));
+ template <class T> V8_INLINE static Value* Cast(T* value);
private:
- V8_INLINE(bool QuickIsUndefined() const);
- V8_INLINE(bool QuickIsNull() const);
- V8_INLINE(bool QuickIsString() const);
+ V8_INLINE bool QuickIsUndefined() const;
+ V8_INLINE bool QuickIsNull() const;
+ V8_INLINE bool QuickIsString() const;
bool FullIsUndefined() const;
bool FullIsNull() const;
bool FullIsString() const;
@@ -1492,7 +1489,7 @@
class V8_EXPORT Boolean : public Primitive {
public:
bool Value() const;
- V8_INLINE(static Handle<Boolean> New(bool value));
+ V8_INLINE static Handle<Boolean> New(bool value);
};
@@ -1521,7 +1518,7 @@
/**
* This function is no longer useful.
*/
- V8_DEPRECATED(V8_INLINE(bool MayContainNonAscii()) const) { return true;
}
+ V8_DEPRECATED(V8_INLINE bool MayContainNonAscii() const) { return true; }
/**
* Returns whether this string is known to contain only one byte data.
@@ -1593,7 +1590,7 @@
* A zero length string.
*/
static v8::Local<v8::String> Empty();
- V8_INLINE(static v8::Local<v8::String> Empty(Isolate* isolate));
+ V8_INLINE static v8::Local<v8::String> Empty(Isolate* isolate);
/**
* Returns true if the string is external
@@ -1691,14 +1688,14 @@
* regardless of the encoding, otherwise return NULL. The encoding of
the
* string is returned in encoding_out.
*/
- V8_INLINE(ExternalStringResourceBase* GetExternalStringResourceBase(
- Encoding* encoding_out) const);
+ V8_INLINE ExternalStringResourceBase* GetExternalStringResourceBase(
+ Encoding* encoding_out) const;
/**
* Get the ExternalStringResource for an external string. Returns
* NULL if IsExternal() doesn't return true.
*/
- V8_INLINE(ExternalStringResource* GetExternalStringResource() const);
+ V8_INLINE ExternalStringResource* GetExternalStringResource() const;
/**
* Get the ExternalAsciiStringResource for an external ASCII string.
@@ -1706,7 +1703,7 @@
*/
const ExternalAsciiStringResource* GetExternalAsciiStringResource()
const;
- V8_INLINE(static String* Cast(v8::Value* obj));
+ V8_INLINE static String* Cast(v8::Value* obj);
// TODO(dcarney): deprecate
/**
@@ -1714,18 +1711,18 @@
* The second parameter 'length' gives the buffer length. If omitted,
* the function calls 'strlen' to determine the buffer length.
*/
- V8_INLINE(static Local<String> New(const char* data, int length = -1));
+ V8_INLINE static Local<String> New(const char* data, int length = -1);
// TODO(dcarney): deprecate
/** Allocates a new string from 16-bit character codes.*/
- V8_INLINE(static Local<String> New(const uint16_t* data, int length =
-1));
+ V8_INLINE static Local<String> New(const uint16_t* data, int length =
-1);
// TODO(dcarney): deprecate
/**
* Creates an internalized string (historically called a "symbol",
* not to be confused with ES6 symbols). Returns one if it exists
already.
*/
- V8_INLINE(static Local<String> NewSymbol(const char* data, int length =
-1));
+ V8_INLINE static Local<String> NewSymbol(const char* data, int length =
-1);
enum NewStringType {
kNormalString, kInternalizedString, kUndetectableString
@@ -1806,13 +1803,13 @@
// TODO(dcarney): deprecate
/** Creates an undetectable string from the supplied ASCII or UTF-8
data.*/
- V8_INLINE(
- static Local<String> NewUndetectable(const char* data, int length =
-1));
+ V8_INLINE static Local<String> NewUndetectable(const char* data,
+ int length = -1);
// TODO(dcarney): deprecate
/** Creates an undetectable string from the supplied 16-bit character
codes.*/
- V8_INLINE(static Local<String> NewUndetectable(
- const uint16_t* data, int length = -1));
+ V8_INLINE static Local<String> NewUndetectable(const uint16_t* data,
+ int length = -1);
/**
* Converts an object to a UTF-8-encoded character array. Useful if
@@ -1907,7 +1904,7 @@
// Create a symbol with a print name.
static Local<Symbol> New(Isolate *isolate, const char* data, int length
= -1);
- V8_INLINE(static Symbol* Cast(v8::Value* obj));
+ V8_INLINE static Symbol* Cast(v8::Value* obj);
private:
Symbol();
static void CheckCast(v8::Value* obj);
@@ -1922,7 +1919,7 @@
double Value() const;
static Local<Number> New(double value);
static Local<Number> New(Isolate* isolate, double value);
- V8_INLINE(static Number* Cast(v8::Value* obj));
+ V8_INLINE static Number* Cast(v8::Value* obj);
private:
Number();
static void CheckCast(v8::Value* obj);
@@ -1939,7 +1936,7 @@
static Local<Integer> New(int32_t value, Isolate*);
static Local<Integer> NewFromUnsigned(uint32_t value, Isolate*);
int64_t Value() const;
- V8_INLINE(static Integer* Cast(v8::Value* obj));
+ V8_INLINE static Integer* Cast(v8::Value* obj);
private:
Integer();
static void CheckCast(v8::Value* obj);
@@ -2140,7 +2137,7 @@
int InternalFieldCount();
/** Gets the value from an internal field. */
- V8_INLINE(Local<Value> GetInternalField(int index));
+ V8_INLINE Local<Value> GetInternalField(int index);
/** Sets the value in an internal field. */
void SetInternalField(int index, Handle<Value> value);
@@ -2150,7 +2147,7 @@
* must have been set by SetAlignedPointerInInternalField, everything
else
* leads to undefined behavior.
*/
- V8_INLINE(void* GetAlignedPointerFromInternalField(int index));
+ V8_INLINE void* GetAlignedPointerFromInternalField(int index);
/**
* Sets a 2-byte-aligned native pointer in an internal field. To
retrieve such
@@ -2280,7 +2277,7 @@
Local<Value> CallAsConstructor(int argc, Handle<Value> argv[]);
static Local<Object> New();
- V8_INLINE(static Object* Cast(Value* obj));
+ V8_INLINE static Object* Cast(Value* obj);
private:
Object();
@@ -2309,7 +2306,7 @@
*/
static Local<Array> New(int length = 0);
- V8_INLINE(static Array* Cast(Value* obj));
+ V8_INLINE static Array* Cast(Value* obj);
private:
Array();
static void CheckCast(Value* obj);
@@ -2319,31 +2316,31 @@
template<typename T>
class ReturnValue {
public:
- template <class S> V8_INLINE(ReturnValue(const ReturnValue<S>& that))
+ template <class S> V8_INLINE ReturnValue(const ReturnValue<S>& that)
: value_(that.value_) {
TYPE_CHECK(T, S);
}
// Handle setters
- template <typename S> V8_INLINE(void Set(const Persistent<S>& handle));
- template <typename S> V8_INLINE(void Set(const Handle<S> handle));
+ template <typename S> V8_INLINE void Set(const Persistent<S>& handle);
+ template <typename S> V8_INLINE void Set(const Handle<S> handle);
// Fast primitive setters
- V8_INLINE(void Set(bool value));
- V8_INLINE(void Set(double i));
- V8_INLINE(void Set(int32_t i));
- V8_INLINE(void Set(uint32_t i));
+ V8_INLINE void Set(bool value);
+ V8_INLINE void Set(double i);
+ V8_INLINE void Set(int32_t i);
+ V8_INLINE void Set(uint32_t i);
// Fast JS primitive setters
- V8_INLINE(void SetNull());
- V8_INLINE(void SetUndefined());
- V8_INLINE(void SetEmptyString());
+ V8_INLINE void SetNull();
+ V8_INLINE void SetUndefined();
+ V8_INLINE void SetEmptyString();
// Convenience getter for Isolate
- V8_INLINE(Isolate* GetIsolate());
+ V8_INLINE Isolate* GetIsolate();
private:
template<class F> friend class ReturnValue;
template<class F> friend class FunctionCallbackInfo;
template<class F> friend class PropertyCallbackInfo;
- V8_INLINE(internal::Object* GetDefaultValue());
- V8_INLINE(explicit ReturnValue(internal::Object** slot));
+ V8_INLINE internal::Object* GetDefaultValue();
+ V8_INLINE explicit ReturnValue(internal::Object** slot);
internal::Object** value_;
};
@@ -2357,15 +2354,15 @@
template<typename T>
class FunctionCallbackInfo {
public:
- V8_INLINE(int Length() const);
- V8_INLINE(Local<Value> operator[](int i) const);
- V8_INLINE(Local<Function> Callee() const);
- V8_INLINE(Local<Object> This() const);
- V8_INLINE(Local<Object> Holder() const);
- V8_INLINE(bool IsConstructCall() const);
- V8_INLINE(Local<Value> Data() const);
- V8_INLINE(Isolate* GetIsolate() const);
- V8_INLINE(ReturnValue<T> GetReturnValue() const);
+ V8_INLINE int Length() const;
+ V8_INLINE Local<Value> operator[](int i) const;
+ V8_INLINE Local<Function> Callee() const;
+ V8_INLINE Local<Object> This() const;
+ V8_INLINE Local<Object> Holder() const;
+ V8_INLINE bool IsConstructCall() const;
+ V8_INLINE Local<Value> Data() const;
+ V8_INLINE Isolate* GetIsolate() const;
+ V8_INLINE ReturnValue<T> GetReturnValue() const;
// This shouldn't be public, but the arm compiler needs it.
static const int kArgsLength = 6;
@@ -2379,10 +2376,10 @@
static const int kCalleeIndex = -4;
static const int kHolderIndex = -5;
- V8_INLINE(FunctionCallbackInfo(internal::Object** implicit_args,
+ V8_INLINE FunctionCallbackInfo(internal::Object** implicit_args,
internal::Object** values,
int length,
- bool is_construct_call));
+ bool is_construct_call);
internal::Object** implicit_args_;
internal::Object** values_;
int length_;
@@ -2397,11 +2394,11 @@
template<typename T>
class PropertyCallbackInfo {
public:
- V8_INLINE(Isolate* GetIsolate() const);
- V8_INLINE(Local<Value> Data() const);
- V8_INLINE(Local<Object> This() const);
- V8_INLINE(Local<Object> Holder() const);
- V8_INLINE(ReturnValue<T> GetReturnValue() const);
+ V8_INLINE Isolate* GetIsolate() const;
+ V8_INLINE Local<Value> Data() const;
+ V8_INLINE Local<Object> This() const;
+ V8_INLINE Local<Object> Holder() const;
+ V8_INLINE ReturnValue<T> GetReturnValue() const;
// This shouldn't be public, but the arm compiler needs it.
static const int kArgsLength = 6;
@@ -2416,8 +2413,7 @@
static const int kReturnValueDefaultValueIndex = -4;
static const int kIsolateIndex = -5;
- V8_INLINE(PropertyCallbackInfo(internal::Object** args))
- : args_(args) { }
+ V8_INLINE PropertyCallbackInfo(internal::Object** args) : args_(args) {}
internal::Object** args_;
};
@@ -2476,7 +2472,7 @@
int ScriptId() const;
ScriptOrigin GetScriptOrigin() const;
- V8_INLINE(static Function* Cast(Value* obj));
+ V8_INLINE static Function* Cast(Value* obj);
static const int kLineOffsetNotFound;
private:
@@ -2595,7 +2591,7 @@
*/
Contents Externalize();
- V8_INLINE(static ArrayBuffer* Cast(Value* obj));
+ V8_INLINE static ArrayBuffer* Cast(Value* obj);
static const int kInternalFieldCount =
V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT;
@@ -2636,7 +2632,7 @@
*/
void* BaseAddress();
- V8_INLINE(static ArrayBufferView* Cast(Value* obj));
+ V8_INLINE static ArrayBufferView* Cast(Value* obj);
static const int kInternalFieldCount =
V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT;
@@ -2660,7 +2656,7 @@
*/
size_t Length();
- V8_INLINE(static TypedArray* Cast(Value* obj));
+ V8_INLINE static TypedArray* Cast(Value* obj);
private:
TypedArray();
@@ -2676,7 +2672,7 @@
public:
static Local<Uint8Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Uint8Array* Cast(Value* obj));
+ V8_INLINE static Uint8Array* Cast(Value* obj);
private:
Uint8Array();
@@ -2692,7 +2688,7 @@
public:
static Local<Uint8ClampedArray> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Uint8ClampedArray* Cast(Value* obj));
+ V8_INLINE static Uint8ClampedArray* Cast(Value* obj);
private:
Uint8ClampedArray();
@@ -2707,7 +2703,7 @@
public:
static Local<Int8Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Int8Array* Cast(Value* obj));
+ V8_INLINE static Int8Array* Cast(Value* obj);
private:
Int8Array();
@@ -2723,7 +2719,7 @@
public:
static Local<Uint16Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Uint16Array* Cast(Value* obj));
+ V8_INLINE static Uint16Array* Cast(Value* obj);
private:
Uint16Array();
@@ -2739,7 +2735,7 @@
public:
static Local<Int16Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Int16Array* Cast(Value* obj));
+ V8_INLINE static Int16Array* Cast(Value* obj);
private:
Int16Array();
@@ -2755,7 +2751,7 @@
public:
static Local<Uint32Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Uint32Array* Cast(Value* obj));
+ V8_INLINE static Uint32Array* Cast(Value* obj);
private:
Uint32Array();
@@ -2771,7 +2767,7 @@
public:
static Local<Int32Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Int32Array* Cast(Value* obj));
+ V8_INLINE static Int32Array* Cast(Value* obj);
private:
Int32Array();
@@ -2787,7 +2783,7 @@
public:
static Local<Float32Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Float32Array* Cast(Value* obj));
+ V8_INLINE static Float32Array* Cast(Value* obj);
private:
Float32Array();
@@ -2803,7 +2799,7 @@
public:
static Local<Float64Array> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static Float64Array* Cast(Value* obj));
+ V8_INLINE static Float64Array* Cast(Value* obj);
private:
Float64Array();
@@ -2819,7 +2815,7 @@
public:
static Local<DataView> New(Handle<ArrayBuffer> array_buffer,
size_t byte_offset, size_t length);
- V8_INLINE(static DataView* Cast(Value* obj));
+ V8_INLINE static DataView* Cast(Value* obj);
private:
DataView();
@@ -2844,7 +2840,7 @@
*/
double ValueOf() const;
- V8_INLINE(static Date* Cast(v8::Value* obj));
+ V8_INLINE static Date* Cast(v8::Value* obj);
/**
* Notification that the embedder has changed the time zone,
@@ -2881,7 +2877,7 @@
*/
double ValueOf() const;
***The diff for this file has been truncated for email.***
=======================================
--- /branches/bleeding_edge/include/v8config.h Wed Sep 11 18:30:01 2013 UTC
+++ /branches/bleeding_edge/include/v8config.h Thu Sep 12 08:57:10 2013 UTC
@@ -295,23 +295,27 @@
// Helper macros
// A macro used to make better inlining. Don't bother for debug builds.
+// Use like:
+// V8_INLINE int GetZero() { return 0; }
#if !defined(DEBUG) && V8_HAS_ATTRIBUTE_ALWAYS_INLINE
-# define V8_INLINE(declarator) inline __attribute__((always_inline))
declarator
+# define V8_INLINE inline __attribute__((always_inline))
#elif !defined(DEBUG) && V8_HAS___FORCEINLINE
-# define V8_INLINE(declarator) __forceinline declarator
+# define V8_INLINE __forceinline
#else
-# define V8_INLINE(declarator) inline declarator
+# define V8_INLINE inline
#endif
// A macro used to tell the compiler to never inline a particular function.
// Don't bother for debug builds.
+// Use like:
+// V8_NOINLINE int GetMinusOne() { return -1; }
#if !defined(DEBUG) && V8_HAS_ATTRIBUTE_NOINLINE
-# define V8_NOINLINE(declarator) __attribute__((noinline)) declarator
+# define V8_NOINLINE __attribute__((noinline))
#elif !defined(DEBUG) && V8_HAS_DECLSPEC_NOINLINE
-# define V8_NOINLINE(declarator) __declspec(noinline) declarator
+# define V8_NOINLINE __declspec(noinline)
#else
-# define V8_NOINLINE(declarator) declarator
+# define V8_NOINLINE /* NOT SUPPORTED */
#endif
=======================================
--- /branches/bleeding_edge/src/cpu.cc Wed Sep 11 18:30:01 2013 UTC
+++ /branches/bleeding_edge/src/cpu.cc Thu Sep 12 08:57:10 2013 UTC
@@ -54,7 +54,7 @@
// Define __cpuid() for non-MSVC compilers.
#if !V8_CC_MSVC
-static V8_INLINE(void __cpuid(int cpu_info[4], int info_type)) {
+static V8_INLINE void __cpuid(int cpu_info[4], int info_type) {
#if defined(__i386__) && defined(__pic__)
// Make sure to preserve ebx, which contains the pointer
// to the GOT in case we're generating PIC.
=======================================
--- /branches/bleeding_edge/src/globals.h Wed Sep 11 18:30:01 2013 UTC
+++ /branches/bleeding_edge/src/globals.h Thu Sep 12 08:57:10 2013 UTC
@@ -342,9 +342,9 @@
DISALLOW_COPY_AND_ASSIGN(TypeName)
-// Newly written code should use V8_INLINE() and V8_NOINLINE() directly.
-#define INLINE(declarator) V8_INLINE(declarator)
-#define NO_INLINE(declarator) V8_NOINLINE(declarator)
+// Newly written code should use V8_INLINE and V8_NOINLINE directly.
+#define INLINE(declarator) V8_INLINE declarator
+#define NO_INLINE(declarator) V8_NOINLINE declarator
// Newly written code should use V8_WARN_UNUSED_RESULT.
=======================================
--- /branches/bleeding_edge/src/platform/elapsed-timer.h Wed Sep 11
18:30:01 2013 UTC
+++ /branches/bleeding_edge/src/platform/elapsed-timer.h Thu Sep 12
08:57:10 2013 UTC
@@ -103,7 +103,7 @@
}
private:
- V8_INLINE(static TimeTicks Now()) {
+ static V8_INLINE TimeTicks Now() {
TimeTicks now = TimeTicks::HighResNow();
ASSERT(!now.IsNull());
return now;
=======================================
--- /branches/bleeding_edge/src/platform/mutex.cc Wed Sep 11 18:30:01 2013
UTC
+++ /branches/bleeding_edge/src/platform/mutex.cc Thu Sep 12 08:57:10 2013
UTC
@@ -34,7 +34,7 @@
#if V8_OS_POSIX
-static V8_INLINE(void InitializeNativeHandle(pthread_mutex_t* mutex)) {
+static V8_INLINE void InitializeNativeHandle(pthread_mutex_t* mutex) {
int result;
#if defined(DEBUG)
// Use an error checking mutex in debug mode.
@@ -55,7 +55,7 @@
}
-static V8_INLINE(void InitializeRecursiveNativeHandle(pthread_mutex_t*
mutex)) {
+static V8_INLINE void InitializeRecursiveNativeHandle(pthread_mutex_t*
mutex) {
pthread_mutexattr_t attr;
int result = pthread_mutexattr_init(&attr);
ASSERT_EQ(0, result);
@@ -69,28 +69,28 @@
}
-static V8_INLINE(void DestroyNativeHandle(pthread_mutex_t* mutex)) {
+static V8_INLINE void DestroyNativeHandle(pthread_mutex_t* mutex) {
int result = pthread_mutex_destroy(mutex);
ASSERT_EQ(0, result);
USE(result);
}
-static V8_INLINE(void LockNativeHandle(pthread_mutex_t* mutex)) {
+static V8_INLINE void LockNativeHandle(pthread_mutex_t* mutex) {
int result = pthread_mutex_lock(mutex);
ASSERT_EQ(0, result);
USE(result);
}
-static V8_INLINE(void UnlockNativeHandle(pthread_mutex_t* mutex)) {
+static V8_INLINE void UnlockNativeHandle(pthread_mutex_t* mutex) {
int result = pthread_mutex_unlock(mutex);
ASSERT_EQ(0, result);
USE(result);
}
-static V8_INLINE(bool TryLockNativeHandle(pthread_mutex_t* mutex)) {
+static V8_INLINE bool TryLockNativeHandle(pthread_mutex_t* mutex) {
int result = pthread_mutex_trylock(mutex);
if (result == EBUSY) {
return false;
@@ -101,32 +101,32 @@
#elif V8_OS_WIN
-static V8_INLINE(void InitializeNativeHandle(PCRITICAL_SECTION cs)) {
+static V8_INLINE void InitializeNativeHandle(PCRITICAL_SECTION cs) {
InitializeCriticalSection(cs);
}
-static V8_INLINE(void InitializeRecursiveNativeHandle(PCRITICAL_SECTION
cs)) {
+static V8_INLINE void InitializeRecursiveNativeHandle(PCRITICAL_SECTION
cs) {
InitializeCriticalSection(cs);
}
-static V8_INLINE(void DestroyNativeHandle(PCRITICAL_SECTION cs)) {
+static V8_INLINE void DestroyNativeHandle(PCRITICAL_SECTION cs) {
DeleteCriticalSection(cs);
}
-static V8_INLINE(void LockNativeHandle(PCRITICAL_SECTION cs)) {
+static V8_INLINE void LockNativeHandle(PCRITICAL_SECTION cs) {
EnterCriticalSection(cs);
}
-static V8_INLINE(void UnlockNativeHandle(PCRITICAL_SECTION cs)) {
+static V8_INLINE void UnlockNativeHandle(PCRITICAL_SECTION cs) {
LeaveCriticalSection(cs);
}
-static V8_INLINE(bool TryLockNativeHandle(PCRITICAL_SECTION cs)) {
+static V8_INLINE bool TryLockNativeHandle(PCRITICAL_SECTION cs) {
return TryEnterCriticalSection(cs);
}
=======================================
--- /branches/bleeding_edge/src/platform/mutex.h Wed Sep 11 18:30:01 2013
UTC
+++ /branches/bleeding_edge/src/platform/mutex.h Thu Sep 12 08:57:10 2013
UTC
@@ -94,14 +94,14 @@
int level_;
#endif
- V8_INLINE(void AssertHeldAndUnmark()) {
+ V8_INLINE void AssertHeldAndUnmark() {
#ifdef DEBUG
ASSERT_EQ(1, level_);
level_--;
#endif
}
- V8_INLINE(void AssertUnheldAndMark()) {
+ V8_INLINE void AssertUnheldAndMark() {
#ifdef DEBUG
ASSERT_EQ(0, level_);
level_++;
=======================================
--- /branches/bleeding_edge/src/platform/socket.h Wed Sep 11 18:30:01 2013
UTC
+++ /branches/bleeding_edge/src/platform/socket.h Thu Sep 12 08:57:10 2013
UTC
@@ -66,7 +66,7 @@
// Set the value of the SO_REUSEADDR socket option.
bool SetReuseAddress(bool reuse_address);
- V8_INLINE(bool IsValid()) const {
+ V8_INLINE bool IsValid() const {
return native_handle_ != kInvalidNativeHandle;
}
=======================================
--- /branches/bleeding_edge/src/spaces.h Wed Sep 11 18:30:01 2013 UTC
+++ /branches/bleeding_edge/src/spaces.h Thu Sep 12 08:57:10 2013 UTC
@@ -1085,7 +1085,7 @@
// Returns an indication of whether a pointer is in a space that has
// been allocated by this MemoryAllocator.
- V8_INLINE(bool IsOutsideAllocatedSpace(const void* address)) const {
+ V8_INLINE bool IsOutsideAllocatedSpace(const void* address) const {
return address < lowest_ever_allocated_ ||
address >= highest_ever_allocated_;
}
=======================================
--- /branches/bleeding_edge/src/utils/random-number-generator.h Wed Sep 11
18:30:01 2013 UTC
+++ /branches/bleeding_edge/src/utils/random-number-generator.h Thu Sep 12
08:57:10 2013 UTC
@@ -59,7 +59,7 @@
// that one int value is pseudorandomly generated and returned.
// All 2^32 possible integer values are produced with (approximately)
equal
// probability.
- V8_INLINE(int NextInt()) V8_WARN_UNUSED_RESULT {
+ V8_INLINE int NextInt() V8_WARN_UNUSED_RESULT {
return Next(32);
}
@@ -76,7 +76,7 @@
// |NextBoolean()| is that one boolean value is pseudorandomly generated
and
// returned. The values true and false are produced with (approximately)
equal
// probability.
- V8_INLINE(bool NextBool()) V8_WARN_UNUSED_RESULT {
+ V8_INLINE bool NextBool() V8_WARN_UNUSED_RESULT {
return Next(1) != 0;
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Wed Sep 11 18:30:01
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-api.cc Thu Sep 12 08:57:10
2013 UTC
@@ -12670,8 +12670,8 @@
typedef Persistent<T, CopyablePersistentTraits<T> > CopyablePersistent;
static const bool kResetInDestructor = true;
template<class S, class M>
- V8_INLINE(static void Copy(const Persistent<S, M>& source,
- CopyablePersistent* dest)) {
+ static V8_INLINE void Copy(const Persistent<S, M>& source,
+ CopyablePersistent* dest) {
// do nothing, just allow copy
}
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
